From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F135C433FF for ; Mon, 29 Jul 2019 19:25:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0458B2070B for ; Mon, 29 Jul 2019 19:25:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729709AbfG2TZw (ORCPT ); Mon, 29 Jul 2019 15:25:52 -0400 Received: from mail-vs1-f66.google.com ([209.85.217.66]:36331 "EHLO mail-vs1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729714AbfG2TZv (ORCPT ); Mon, 29 Jul 2019 15:25:51 -0400 Received: by mail-vs1-f66.google.com with SMTP id y16so41697556vsc.3 for ; Mon, 29 Jul 2019 12:25:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KuDwyfFjeNA7MHLSVk0PfrBhoChP/xZ4V/mRYLTptI4=; b=S5dYocii2HXXSt+hMsmYfp5xM1xwGN8o2L68GtWCew/HW7Yd3gnPoyDhO/UHxv1Xe3 V62NGnFBAkS3vvL4D1iNchnlOFVoBmPHARFJ2bUrXhWd53VHSXHyfB1Gm2bFdVrmIdn7 tWMAdpY+/tWIe/TWlGDMoGfY3p0PSZl2iBR+G7kHMKVvFh3gS833Bv2c1pTa7vlweckY 6aYp1lZaMk+s25oa2S9EndicMEyWICUDxaJOPE/hZQuwQjK1I8F5tU0pb28iM2rQ3miE HaO/WWEg8g+kjVE/sP+fDNPREr3BMAbnnxVuYPb/wq7xGDg8p9rXsfryx/gA2s5D/HRX NgxQ== X-Gm-Message-State: APjAAAXun3iR57TaF/FHi9zkcuaYeY/Y42kzLyTLlrtKAFlJvH2TJv1C Vaylcg4AbzbaKc7bc+NkvHLxkQ== X-Google-Smtp-Source: APXvYqyXXOall2jCflvinWC2gaIT9BD0Z5K7BVc2aKd3WT2Zxcla5B9AwA2EkqMiUXMUo+1dx/BnWw== X-Received: by 2002:a67:2c50:: with SMTP id s77mr69962386vss.50.1564428350830; Mon, 29 Jul 2019 12:25:50 -0700 (PDT) Received: from redhat.com (bzq-79-181-91-42.red.bezeqint.net. [79.181.91.42]) by smtp.gmail.com with ESMTPSA id w73sm26923160vkh.14.2019.07.29.12.25.45 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 29 Jul 2019 12:25:49 -0700 (PDT) Date: Mon, 29 Jul 2019 15:25:42 -0400 From: "Michael S. Tsirkin" To: Alexander Duyck Cc: wei.w.wang@intel.com, Nitesh Narayan Lal , Alexander Duyck , kvm list , David Hildenbrand , Dave Hansen , LKML , linux-mm , Andrew Morton , Yang Zhang , pagupta@redhat.com, Rik van Riel , Konrad Rzeszutek Wilk , lcapitulino@redhat.com, Andrea Arcangeli , Paolo Bonzini , dan.j.williams@intel.com Subject: Re: [PATCH v2 QEMU] virtio-balloon: Provide a interface for "bubble hinting" Message-ID: <20190729151805-mutt-send-email-mst@kernel.org> References: <20190724165158.6685.87228.stgit@localhost.localdomain> <20190724171050.7888.62199.stgit@localhost.localdomain> <20190724150224-mutt-send-email-mst@kernel.org> <6218af96d7d55935f2cf607d47680edc9b90816e.camel@linux.intel.com> <20190724164023-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Jul 29, 2019 at 09:58:04AM -0700, Alexander Duyck wrote: > On Wed, Jul 24, 2019 at 1:42 PM Michael S. Tsirkin wrote: > > > > On Wed, Jul 24, 2019 at 04:29:27PM -0400, Nitesh Narayan Lal wrote: > > > > > > On 7/24/19 4:18 PM, Alexander Duyck wrote: > > > > On Wed, 2019-07-24 at 15:02 -0400, Michael S. Tsirkin wrote: > > > >> On Wed, Jul 24, 2019 at 10:12:10AM -0700, Alexander Duyck wrote: > > > >>> From: Alexander Duyck > > > >>> > > > >>> Add support for what I am referring to as "bubble hinting". Basically the > > > >>> idea is to function very similar to how the balloon works in that we > > > >>> basically end up madvising the page as not being used. However we don't > > > >>> really need to bother with any deflate type logic since the page will be > > > >>> faulted back into the guest when it is read or written to. > > > >>> > > > >>> This is meant to be a simplification of the existing balloon interface > > > >>> to use for providing hints to what memory needs to be freed. I am assuming > > > >>> this is safe to do as the deflate logic does not actually appear to do very > > > >>> much other than tracking what subpages have been released and which ones > > > >>> haven't. > > > >>> > > > >>> Signed-off-by: Alexander Duyck > > > >>> --- > > > >>> hw/virtio/virtio-balloon.c | 40 +++++++++++++++++++++++ > > > >>> include/hw/virtio/virtio-balloon.h | 2 + > > > >>> include/standard-headers/linux/virtio_balloon.h | 1 + > > > >>> 3 files changed, 42 insertions(+), 1 deletion(-) > > > >>> > > > >>> diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c > > > >>> index 2112874055fb..70c0004c0f88 100644 > > > >>> --- a/hw/virtio/virtio-balloon.c > > > >>> +++ b/hw/virtio/virtio-balloon.c > > > >>> @@ -328,6 +328,39 @@ static void balloon_stats_set_poll_interval(Object *obj, Visitor *v, > > > >>> balloon_stats_change_timer(s, 0); > > > >>> } > > > >>> > > > >>> +static void virtio_bubble_handle_output(VirtIODevice *vdev, VirtQueue *vq) > > > >>> +{ > > > >>> + VirtQueueElement *elem; > > > >>> + > > > >>> + while ((elem = virtqueue_pop(vq, sizeof(VirtQueueElement)))) { > > > >>> + unsigned int i; > > > >>> + > > > >>> + for (i = 0; i < elem->in_num; i++) { > > > >>> + void *addr = elem->in_sg[i].iov_base; > > > >>> + size_t size = elem->in_sg[i].iov_len; > > > >>> + ram_addr_t ram_offset; > > > >>> + size_t rb_page_size; > > > >>> + RAMBlock *rb; > > > >>> + > > > >>> + if (qemu_balloon_is_inhibited()) > > > >>> + continue; > > > >>> + > > > >>> + rb = qemu_ram_block_from_host(addr, false, &ram_offset); > > > >>> + rb_page_size = qemu_ram_pagesize(rb); > > > >>> + > > > >>> + /* For now we will simply ignore unaligned memory regions */ > > > >>> + if ((ram_offset | size) & (rb_page_size - 1)) > > > >>> + continue; > > > >>> + > > > >>> + ram_block_discard_range(rb, ram_offset, size); > > > >> I suspect this needs to do like the migration type of > > > >> hinting and get disabled if page poisoning is in effect. > > > >> Right? > > > > Shouldn't something like that end up getting handled via > > > > qemu_balloon_is_inhibited, or did I miss something there? I assumed cases > > > > like that would end up setting qemu_balloon_is_inhibited to true, if that > > > > isn't the case then I could add some additional conditions. I would do it > > > > in about the same spot as the qemu_balloon_is_inhibited check. > > > I don't think qemu_balloon_is_inhibited() will take care of the page poisoning > > > situations. > > > If I am not wrong we may have to look to extend VIRTIO_BALLOON_F_PAGE_POISON > > > support as per Michael's suggestion. > > > > > > BTW upstream qemu seems to ignore VIRTIO_BALLOON_F_PAGE_POISON ATM. > > Which is probably a bug. > > Wei, could you take a look pls? > > So I was looking at sorting out this for the unused page reporting > that I am working on and it occurred to me that I don't think we can > do the free page hinting if any sort of poison validation is present. > The problem is that free page hinting simply stops the page from being > migrated. As a result if there was stale data present it will just > leave it there instead of zeroing it or writing it to alternating 1s > and 0s. stale data where? on source or on destination? do you mean the case where memory was corrupted? > > Also it looks like the VIRTIO_BALLOON_F_PAGE_POISON feature is > assuming that 0 means that page poisoning is disabled, > when in reality > it might just mean we are using the value zero to poison pages instead > of the 0xaa pattern. As such I think there are several cases where we > could incorrectly flag the pages with the hint and result in the > migrated guest reporting pages that contain non-poison values. > Well guest has this code: static int virtballoon_validate(struct virtio_device *vdev) { if (!page_poisoning_enabled()) __virtio_clear_bit(vdev, VIRTIO_BALLOON_F_PAGE_POISON); __virtio_clear_bit(vdev, VIRTIO_F_IOMMU_PLATFORM); return 0; } So it seems that host can figure out what is going on easily enough. What did I miss? > The zero assumption works for unused page reporting since we will be > zeroing out the page when it is faulted back into the guest, however > the same doesn't work for the free page hint since it is simply > skipping the migration of the recently dirtied page. Right but the dirtied page is normally full of 0 since that is the poison value, if we just leave it there we still get 0s, right? -- MST