Re: [PATCH RESEND v4 8/9] KVM: MMU: Enable Lazy mode SPPT setup

Yang Weijiang
2019-08-20T13:10:50Z

On Mon, Aug 19, 2019 at 04:46:54PM +0200, Paolo Bonzini wrote:
> On 14/08/19 09:04, Yang Weijiang wrote:
> > +
> > + if (vcpu->kvm->arch.spp_active && level == PT_PAGE_TABLE_LEVEL)
> > + kvm_enable_spp_protection(vcpu->kvm, gfn);
> > +
>
> This would not enable SPP if the guest is backed by huge pages.
> Instead, either the PT_PAGE_TABLE_LEVEL level must be forced for all
> pages covered by SPP ranges, or (better) kvm_enable_spp_protection must
> be able to cover multiple pages at once.
>
> Paolo
OK, I'll figure out how to make it, thanks!