Re: [kvm-unit-tests PATCH] s390x: Add diag308 subcode 0 testing

Thomas Huth
2019-08-23T14:13:05Z

On 8/22/19 1:11 PM, Janosch Frank wrote:
> By adding a load reset routine to cstart.S we can also test the clear
> reset done by subcode 0, as we now can restore our registers again.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> ---
> I managed to extract this from another bigger test, so let's add it to the bunch.
> I'd be very happy about assembly review :-)

FWIW, the assembly code looks fine to me.

> ---
> s390x/cstart64.S | 27 +++++++++++++++++++++++++++
> s390x/diag308.c | 31 ++++++++++---------------------
> 2 files changed, 37 insertions(+), 21 deletions(-)
>
> diff --git a/s390x/cstart64.S b/s390x/cstart64.S
> index dedfe80..47045e1 100644
> --- a/s390x/cstart64.S
> +++ b/s390x/cstart64.S
> @@ -145,6 +145,33 @@ memsetxc:
> .endm
>
> .section .text
> +/*
> + * load_reset calling convention:
> + * %r2 subcode (0 or 1)
> + */
> +.globl load_reset
> +load_reset:

Maybe rather name the function diag308_load_reset so that it is clear
that it belongs to the diag308 test?
Or are you going to re-use this function in other tests later?

Anyway,
Reviewed-by: Thomas Huth <thuth@redhat.com>