From: Peter Xu <peterx@redhat.com>
To: Andrew Jones <drjones@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Vitaly Kuznetsov" <vkuznets@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Thomas Huth" <thuth@redhat.com>
Subject: Re: [PATCH 4/4] KVM: selftests: Remove duplicate guest mode handling
Date: Thu, 29 Aug 2019 10:09:35 +0800 [thread overview]
Message-ID: <20190829020935.GG8729@xz-x1> (raw)
In-Reply-To: <20190828114613.a2rvpip45c3ywdnj@kamzik.brq.redhat.com>
On Wed, Aug 28, 2019 at 01:46:13PM +0200, Andrew Jones wrote:
[...]
> > +unsigned int vm_get_page_size(struct kvm_vm *vm)
> > +{
> > + return vm->page_size;
> > +}
> > +
> > +unsigned int vm_get_page_shift(struct kvm_vm *vm)
> > +{
> > + return vm->page_shift;
> > +}
>
> We could get by with just one of the above two, but whatever
Right... and imho if we export kvm_vm struct we don't even any
helpers. :) But I didn't touch that.
> > +
> > +unsigned int vm_get_max_gfn(struct kvm_vm *vm)
> > +{
> > + return vm->max_gfn;
> > +}
> > --
> > 2.21.0
> >
>
> Reviewed-by: Andrew Jones <drjones@redhat.com>
Thanks!
--
Peter Xu
next prev parent reply other threads:[~2019-08-29 2:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 13:10 [PATCH 0/4] KVM: selftests: Introduce VM_MODE_PXXV48_4K Peter Xu
2019-08-27 13:10 ` [PATCH 1/4] KVM: selftests: Move vm type into _vm_create() internally Peter Xu
2019-08-28 11:23 ` Andrew Jones
2019-08-29 1:41 ` Peter Xu
2019-08-27 13:10 ` [PATCH 2/4] KVM: selftests: Create VM earlier for dirty log test Peter Xu
2019-08-28 11:48 ` Andrew Jones
2019-08-27 13:10 ` [PATCH 3/4] KVM: selftests: Introduce VM_MODE_PXXV48_4K Peter Xu
2019-08-28 11:41 ` Andrew Jones
2019-08-29 2:07 ` Peter Xu
2019-08-27 13:10 ` [PATCH 4/4] KVM: selftests: Remove duplicate guest mode handling Peter Xu
2019-08-28 11:46 ` Andrew Jones
2019-08-29 2:09 ` Peter Xu [this message]
2019-08-29 9:22 ` Andrew Jones
2019-08-28 11:51 ` [PATCH 0/4] KVM: selftests: Introduce VM_MODE_PXXV48_4K Andrew Jones
2019-08-28 11:52 ` Andrew Jones
2019-08-29 1:32 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829020935.GG8729@xz-x1 \
--to=peterx@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=thuth@redhat.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox