From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09E3BC3A5A1 for ; Thu, 29 Aug 2019 02:09:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D96F12077B for ; Thu, 29 Aug 2019 02:09:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726825AbfH2CJr (ORCPT ); Wed, 28 Aug 2019 22:09:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45012 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726319AbfH2CJr (ORCPT ); Wed, 28 Aug 2019 22:09:47 -0400 Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 42234C054907 for ; Thu, 29 Aug 2019 02:09:47 +0000 (UTC) Received: by mail-pf1-f199.google.com with SMTP id w16so1238116pfn.12 for ; Wed, 28 Aug 2019 19:09:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cWz9sGB+WBliUQqYKGmTy4CKie+Spvd6Fx2kg3YzjVg=; b=hivCUaD0Iv29NrgcLJEn/yinv5qfs5Ad5FByrvoIBfpc1Wq3QRe7VNJuQMZ1m/mH7+ gudxZLJytfNZVOrcIKdVlwbSx1uyvRV+CcTAcobDhP3Q6P5Iz+7nFhUemocUJ7SA3lqC vq7yWNuPat19iWauEfEQ4nN6Fo7LcPC0sLA8ImEwuNB8k8YM0gXqMP/CIH+4vZN5J432 JlUkdeLxTiPVPXRIOGkSrcc1jxyQrkQtfyuyMoAF+N7A1hS9vO8EVc21GtTituV/5RGz pG9/o9AhCD78ocgwmWvOlMP//A9WR2AE+YYhv4JmPl3leNQgtBC7CmlWtqOgbxaiJmyw 0vTQ== X-Gm-Message-State: APjAAAXF++EiCHlAoAWmQwuIzwXwrKZhc//BDW3Qld5BVsNfTaijHa5g UlIrwC8FjYDpuxpcUkeCgpXIvlxaaOG1AZHBSUbNWP791eR4UB94iWtupfcgDEUIOPxxSyA/bAy 8PRmxs1zcOw3L X-Received: by 2002:a17:90a:fa95:: with SMTP id cu21mr7538036pjb.43.1567044586744; Wed, 28 Aug 2019 19:09:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqydpBl4a4u3UFZMu8NHSxmpgKb5IpM9yElt8QSTfIHghvIUhueai7ynoRWwLrFVTt0WrknE2Q== X-Received: by 2002:a17:90a:fa95:: with SMTP id cu21mr7538021pjb.43.1567044586575; Wed, 28 Aug 2019 19:09:46 -0700 (PDT) Received: from xz-x1 ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id x128sm772805pfd.52.2019.08.28.19.09.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2019 19:09:45 -0700 (PDT) Date: Thu, 29 Aug 2019 10:09:35 +0800 From: Peter Xu To: Andrew Jones Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Paolo Bonzini , Vitaly Kuznetsov , Radim =?utf-8?B?S3LEjW3DocWZ?= , Thomas Huth Subject: Re: [PATCH 4/4] KVM: selftests: Remove duplicate guest mode handling Message-ID: <20190829020935.GG8729@xz-x1> References: <20190827131015.21691-1-peterx@redhat.com> <20190827131015.21691-5-peterx@redhat.com> <20190828114613.a2rvpip45c3ywdnj@kamzik.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190828114613.a2rvpip45c3ywdnj@kamzik.brq.redhat.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Aug 28, 2019 at 01:46:13PM +0200, Andrew Jones wrote: [...] > > +unsigned int vm_get_page_size(struct kvm_vm *vm) > > +{ > > + return vm->page_size; > > +} > > + > > +unsigned int vm_get_page_shift(struct kvm_vm *vm) > > +{ > > + return vm->page_shift; > > +} > > We could get by with just one of the above two, but whatever Right... and imho if we export kvm_vm struct we don't even any helpers. :) But I didn't touch that. > > + > > +unsigned int vm_get_max_gfn(struct kvm_vm *vm) > > +{ > > + return vm->max_gfn; > > +} > > -- > > 2.21.0 > > > > Reviewed-by: Andrew Jones Thanks! -- Peter Xu