Re: [PATCH v3 3/5] mdev: Expose mdev alias in sysfs tree

Cornelia Huck
2019-09-17T10:09:07Z

On Sun, 1 Sep 2019 23:24:34 -0500
Parav Pandit <parav@mellanox.com> wrote:

> Expose the optional alias for an mdev device as a sysfs attribute.
> This way, userspace tools such as udev may make use of the alias, for
> example to create a netdevice name for the mdev.
>
> Updated documentation for optional read only sysfs attribute.
>
> Signed-off-by: Parav Pandit <parav@mellanox.com>
>
> ---
> Changelog:
> v2->v3:
> - Merged sysfs documentation patch with sysfs addition
> - Added more description for alias return value
> v0->v1:
> - Addressed comments from Cornelia Huck
> - Updated commit description
> ---
> Documentation/driver-api/vfio-mediated-device.rst | 9 +++++++++
> drivers/vfio/mdev/mdev_sysfs.c | 13 +++++++++++++
> 2 files changed, 22 insertions(+)
>

(...)

> @@ -281,6 +282,14 @@ Example::
>
> # echo 1 > /sys/bus/mdev/devices/$mdev_UUID/remove
>
> +* alias (read only, optional)
> +Whenever a parent requested to generate an alias, each mdev device of such

s/such/that/

> +parent is assigned unique alias by the mdev core.

s/unique alias/a unique alias/

> +This file shows the alias of the mdev device.
> +
> +Reading file either returns valid alias when assigned or returns error code

s/file/this file/
s/valid alias/a valid alias/
s/error code/the error code/

> +-EOPNOTSUPP when unsupported.
> +
> Mediated device Hot plug
> ------------------------

With the nits above fixed,
Reviewed-by: Cornelia Huck <cohuck@redhat.com>