Re: [kvm-unit-tests PATCH v4 1/2] x86: nvmx: fix bug in __enter_guest()

[Sean Christopherson <sean.j.christopherson@intel.com>]

On Tue, Sep 17, 2019 at 01:16:01PM -0700, Marc Orr wrote:
> __enter_guest() should only set the launched flag when a launch has
> succeeded. Thus, don't set the launched flag when the VMX_ENTRY_FAILURE,
> bit 31, is set in the VMCS exit reason.
> 
> Reviewed-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>
> Signed-off-by: Marc Orr <marcorr@google.com>
> ---
>  x86/vmx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/x86/vmx.c b/x86/vmx.c
> index 6079420db33a..7313c78f15c2 100644
> --- a/x86/vmx.c
> +++ b/x86/vmx.c
> @@ -1820,7 +1820,7 @@ static void __enter_guest(u8 abort_flag, struct vmentry_failure *failure)
>  		abort();
>  	}
>  
> -	if (!failure->early) {
> +	if (!failure->early && !(vmcs_read(EXI_REASON) & VMX_ENTRY_FAILURE)) {

Good enough for now, but struct vmentry_failure really needs to be cleaned
up and renamed.

Reviewed-by: Sean Christopherson <sean.j.christopherson@intel.com>

>  		launched = 1;
>  		check_for_guest_termination();
>  	}
> -- 
> 2.23.0.237.gc6a4ce50a0-goog
>