From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Marc Orr <marcorr@google.com>
Cc: kvm@vger.kernel.org, Jim Mattson <jmattson@google.com>,
Peter Shier <pshier@google.com>,
Krish Sadhukhan <krish.sadhukhan@oracle.com>
Subject: Re: [kvm-unit-tests PATCH v3 2/2] x86: nvmx: test max atomic switch MSRs
Date: Tue, 17 Sep 2019 15:28:18 -0700 [thread overview]
Message-ID: <20190917222818.GB10319@linux.intel.com> (raw)
In-Reply-To: <CAA03e5G94nbVj9vfOr5Gc7x89B6afh3HmxHnMMijtn8SzqgjTA@mail.gmail.com>
On Tue, Sep 17, 2019 at 01:16:27PM -0700, Marc Orr wrote:
> > > + /* Cleanup. */
> > > + vmcs_write(ENT_MSR_LD_CNT, 0);
> > > + vmcs_write(EXI_MSR_LD_CNT, 0);
> > > + vmcs_write(EXI_MSR_ST_CNT, 0);
> > > + for (i = 0; i < cleanup_count; i++) {
> > > + enter_guest();
> > > + skip_exit_vmcall();
> > > + }
> >
> > I'm missing something, why do we need to reenter the guest after setting
> > the count to 0?
>
> It's for the failure code path, which fails to get into the guest and
> skip the single vmcall(). I've refactored the code to make this clear.
> Let me know what you think.
Why is not entering the guest a problem?
next prev parent reply other threads:[~2019-09-17 22:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 18:57 [kvm-unit-tests PATCH v3 1/2] x86: nvmx: fix bug in __enter_guest() Marc Orr
2019-09-17 18:57 ` [kvm-unit-tests PATCH v3 2/2] x86: nvmx: test max atomic switch MSRs Marc Orr
2019-09-17 19:47 ` Sean Christopherson
2019-09-17 20:16 ` Marc Orr
2019-09-17 22:28 ` Sean Christopherson [this message]
2019-09-17 22:35 ` Marc Orr
2019-09-17 21:37 ` Krish Sadhukhan
2019-09-18 22:24 ` Marc Orr
2019-09-17 19:14 ` [kvm-unit-tests PATCH v3 1/2] x86: nvmx: fix bug in __enter_guest() Krish Sadhukhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190917222818.GB10319@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=jmattson@google.com \
--cc=krish.sadhukhan@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=marcorr@google.com \
--cc=pshier@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox