Re: [PATCH] x86: remove memory constraint from "mov" instruction

Sean Christopherson
2019-09-19T21:44:43Z

+cc Paolo, Radim and Marc (to avoid saying the same thing twice)

I recommend having Paolo and Radim in the To: field when sending patches
for KVM or kvm-unit-tests, simply cc'ing the KVM list may not be enough to
ensure Paolo/Radim sees the patch.

https://lkml.kernel.org/r/0d59375c-9313-d31a-4af9-d68115e05d55@redhat.com

On Thu, Sep 12, 2019 at 01:59:44PM -0700, Bill Wendling wrote:
> Remove a bogus memory constraint as x86 does not have a generic
> memory-to-memory "mov" instruction.
>
> Signed-off-by: Bill Wendling <morbo@google.com>

For the actual patch:

Reviewed-by: Sean Christopherson <sean.j.christopherson@intel.com>

> ---
> lib/x86/desc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/x86/desc.c b/lib/x86/desc.c
> index 5f37cef..451f504 100644
> --- a/lib/x86/desc.c
> +++ b/lib/x86/desc.c
> @@ -263,7 +263,7 @@ unsigned exception_error_code(void)
> {
> unsigned short error_code;
>
> - asm("mov %%gs:6, %0" : "=rm"(error_code));
> + asm("mov %%gs:6, %0" : "=r"(error_code));
> return error_code;
> }
>
> --
> 2.23.0.237.gc6a4ce50a0-goog
>