From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7794CC4CEC4 for ; Mon, 23 Sep 2019 15:31:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5441B207FD for ; Mon, 23 Sep 2019 15:31:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727766AbfIWPa6 (ORCPT ); Mon, 23 Sep 2019 11:30:58 -0400 Received: from mga14.intel.com ([192.55.52.115]:28142 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725951AbfIWPa6 (ORCPT ); Mon, 23 Sep 2019 11:30:58 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Sep 2019 08:30:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,540,1559545200"; d="scan'208";a="388521635" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.41]) by fmsmga005.fm.intel.com with ESMTP; 23 Sep 2019 08:30:57 -0700 Date: Mon, 23 Sep 2019 08:30:57 -0700 From: Sean Christopherson To: Paolo Bonzini Cc: Andrea Arcangeli , Vitaly Kuznetsov , "Dr. David Alan Gilbert" , Marcelo Tosatti , Peter Xu , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/17] x86: spec_ctrl: fix SPEC_CTRL initialization after kexec Message-ID: <20190923153057.GA18195@linux.intel.com> References: <20190920212509.2578-1-aarcange@redhat.com> <20190920212509.2578-2-aarcange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Sep 23, 2019 at 12:22:23PM +0200, Paolo Bonzini wrote: > On 20/09/19 23:24, Andrea Arcangeli wrote: > > We can't assume the SPEC_CTRL msr is zero at boot because it could be > > left enabled by a previous kernel booted with > > spec_store_bypass_disable=on. > > > > Without this fix a boot with spec_store_bypass_disable=on followed by > > a kexec boot with spec_store_bypass_disable=off would erroneously and > > unexpectedly leave bit 2 set in SPEC_CTRL. > > > > Signed-off-by: Andrea Arcangeli > > Can you send this out separately, so that Thomas et al. can pick it up > as a bug fix? Can all off the patches that are not directly related to the monolithic conversion be sent separately? AFAICT, patches 01, 03, 07, 08, 14, 15, 16 and 17 are not required or dependent on the conversion to a monolithic module. That's almost half the series...