From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19DFEC4CEC4 for ; Mon, 23 Sep 2019 20:09:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E9475207FD for ; Mon, 23 Sep 2019 20:09:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2502453AbfIWUIt (ORCPT ); Mon, 23 Sep 2019 16:08:49 -0400 Received: from mga14.intel.com ([192.55.52.115]:48601 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726777AbfIWUIt (ORCPT ); Mon, 23 Sep 2019 16:08:49 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Sep 2019 13:08:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,541,1559545200"; d="scan'208";a="203199208" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.41]) by fmsmga001.fm.intel.com with ESMTP; 23 Sep 2019 13:08:48 -0700 Date: Mon, 23 Sep 2019 13:08:48 -0700 From: Sean Christopherson To: Marc Orr Cc: kvm@vger.kernel.org, jmattson@google.com, pshier@google.com, krish.sadhukhan@oracle.com, pbonzini@redhat.com, rkrcmar@redhat.com Subject: Re: [kvm-unit-tests PATCH v6 2/2] x86: nvmx: test max atomic switch MSRs Message-ID: <20190923200848.GK18195@linux.intel.com> References: <20190920222945.235480-1-marcorr@google.com> <20190920222945.235480-2-marcorr@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190920222945.235480-2-marcorr@google.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, Sep 20, 2019 at 03:29:45PM -0700, Marc Orr wrote: > + u32 exit_reason; > + u32 exit_reason_want; > + u32 exit_qual; > + > + enter_guest_with_invalid_guest_state(); > + > + exit_reason = vmcs_read(EXI_REASON); > + exit_reason_want = VMX_FAIL_MSR | VMX_ENTRY_FAILURE; > + report("exit_reason, %u, is %u.", > + exit_reason == exit_reason_want, exit_reason, > + exit_reason_want); > + > + exit_qual = vmcs_read(EXI_QUALIFICATION); > + report("exit_qual, %u, is %u.", exit_qual == max_allowed + 1, > + exit_qual, max_allowed + 1); I'd stick with the more standard "val %u, expected %u" verbiage. E.g.: exit_reason, 34, is 35 versus exit_reason 34, expected 35 The "is" part makes it sound like the value in the VMCS *is* 35.