From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Reto Buerki <reet@codelabs.ch>
Cc: kvm@vger.kernel.org
Subject: Re: [RFC PATCH] KVM: VMX: Always sync CR3 to VMCS in nested_vmx_load_cr3
Date: Thu, 26 Sep 2019 11:38:01 -0700 [thread overview]
Message-ID: <20190926183800.GB4738@linux.intel.com> (raw)
In-Reply-To: <20190926140541.15453-2-reet@codelabs.ch>
On Thu, Sep 26, 2019 at 04:05:41PM +0200, Reto Buerki wrote:
> Required to make a Muen system work on KVM nested.
>
> Signed-off-by: Reto Buerki <reet@codelabs.ch>
> ---
> arch/x86/kvm/vmx/nested.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c
> index 41abc62c9a8a..101b2c0c8480 100644
> --- a/arch/x86/kvm/vmx/nested.c
> +++ b/arch/x86/kvm/vmx/nested.c
> @@ -1008,6 +1008,8 @@ static int nested_vmx_load_cr3(struct kvm_vcpu *vcpu, unsigned long cr3, bool ne
> }
> }
>
> + vmcs_writel(GUEST_CR3, cr3);
This isn't wrong, but it's not the most precise fix. I've figured out
what's going awry, in the process of determining how best to fix the issue.
> +
> if (!nested_ept)
> kvm_mmu_new_cr3(vcpu, cr3, false);
>
> --
> 2.20.1
>
prev parent reply other threads:[~2019-09-26 18:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 14:05 [RFC PATCH 0/1] KVM: VMX: Always sync CR3 to VMCS in nested_vmx_load_cr3 Reto Buerki
2019-09-26 14:05 ` [RFC PATCH] " Reto Buerki
2019-09-26 18:38 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190926183800.GB4738@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=kvm@vger.kernel.org \
--cc=reet@codelabs.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox