From: Andre Przywara <andre.przywara@arm.com>
To: Paolo Bonzini <pbonzini@redhat.com>, Andrew Jones <drjones@redhat.com>
Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org
Subject: [kvm-unit-tests PATCH 3/6] arm: timer: Split variable output data from test name
Date: Fri, 27 Sep 2019 11:42:24 +0100 [thread overview]
Message-ID: <20190927104227.253466-4-andre.przywara@arm.com> (raw)
In-Reply-To: <20190927104227.253466-1-andre.przywara@arm.com>
For some tests we mix variable diagnostic output with the test name,
which leads to variable test line, confusing some higher level
frameworks.
Split the output to always use the same test name for a certain test,
and put diagnostic output on a separate line using the INFO: tag.
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
arm/timer.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arm/timer.c b/arm/timer.c
index f2f6019..0b808d5 100644
--- a/arm/timer.c
+++ b/arm/timer.c
@@ -249,7 +249,8 @@ static void test_timer(struct timer_info *info)
local_irq_enable();
left = info->read_tval();
report("interrupt received after TVAL/WFI", info->irq_received);
- report("timer has expired (%d)", left < 0, left);
+ report("timer has expired", left < 0);
+ report_info("TVAL is %d ticks", left);
}
static void test_vtimer(void)
--
2.17.1
next prev parent reply other threads:[~2019-09-27 10:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 10:42 [kvm-unit-tests PATCH 0/6] arm: Use stable test output lines Andre Przywara
2019-09-27 10:42 ` [kvm-unit-tests PATCH 1/6] arm: gic: check_acked: add test description Andre Przywara
2019-09-27 12:18 ` Andrew Jones
2019-09-27 12:40 ` Andre Przywara
2019-09-27 12:55 ` Andrew Jones
2019-09-27 10:42 ` [kvm-unit-tests PATCH 2/6] arm: gic: Split variable output data from test name Andre Przywara
2019-09-27 12:25 ` Andrew Jones
2019-09-27 10:42 ` Andre Przywara [this message]
2019-09-27 12:25 ` [kvm-unit-tests PATCH 3/6] arm: timer: " Andrew Jones
2019-09-27 10:42 ` [kvm-unit-tests PATCH 4/6] arm: selftest: " Andre Przywara
2019-09-27 12:26 ` Andrew Jones
2019-09-27 10:42 ` [kvm-unit-tests PATCH 5/6] arm: selftest: Make MPIDR output stable Andre Przywara
2019-09-27 12:30 ` Andrew Jones
2019-09-27 10:42 ` [kvm-unit-tests PATCH 6/6] arm: Add missing test name prefix calls Andre Przywara
2019-09-27 12:31 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190927104227.253466-4-andre.przywara@arm.com \
--to=andre.przywara@arm.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox