public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Nadav Amit <namit@vmware.com>
To: pbonzini@redhat.com
Cc: kvm@vger.kernel.org, sean.j.christopherson@intel.com,
	Nadav Amit <namit@vmware.com>
Subject: [kvm-unit-tests PATCH] x86: VMX: MSR_IA32_VMX_MISC[30] is not MBZ
Date: Wed,  2 Oct 2019 11:11:14 -0700	[thread overview]
Message-ID: <20191002181114.3448-1-namit@vmware.com> (raw)

MSR_IA32_VMX_MISC[30] tells whehter "VM entry allows injection of a
software interrupt, software exception, or privileged software exception
with an instruction length of 0".

In other words, it is not MBZ (must be zero), so do not check that it is
cleared.

Signed-off-by: Nadav Amit <namit@vmware.com>
---
 x86/vmx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/x86/vmx.c b/x86/vmx.c
index d518102..647ab49 100644
--- a/x86/vmx.c
+++ b/x86/vmx.c
@@ -1486,7 +1486,7 @@ static void test_vmx_caps(void)
 	report("MSR_IA32_VMX_MISC",
 	       (!(ctrl_cpu_rev[1].clr & CPU_URG) || val & (1ul << 5)) &&
 	       ((val >> 16) & 0x1ff) <= 256 &&
-	       (val & 0xc0007e00) == 0);
+	       (val & 0x80007e00) == 0);
 
 	for (n = 0; n < ARRAY_SIZE(vmx_ctl_msr); n++) {
 		ctrl.val = rdmsr(vmx_ctl_msr[n].index);
-- 
2.17.1


             reply	other threads:[~2019-10-03  1:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-02 18:11 Nadav Amit [this message]
2019-10-03 15:23 ` [kvm-unit-tests PATCH] x86: VMX: MSR_IA32_VMX_MISC[30] is not MBZ Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191002181114.3448-1-namit@vmware.com \
    --to=namit@vmware.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=sean.j.christopherson@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox