* [kvm-unit-tests PATCH] x86: VMX: MSR_IA32_VMX_MISC[30] is not MBZ
@ 2019-10-02 18:11 Nadav Amit
2019-10-03 15:23 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Nadav Amit @ 2019-10-02 18:11 UTC (permalink / raw)
To: pbonzini; +Cc: kvm, sean.j.christopherson, Nadav Amit
MSR_IA32_VMX_MISC[30] tells whehter "VM entry allows injection of a
software interrupt, software exception, or privileged software exception
with an instruction length of 0".
In other words, it is not MBZ (must be zero), so do not check that it is
cleared.
Signed-off-by: Nadav Amit <namit@vmware.com>
---
x86/vmx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/x86/vmx.c b/x86/vmx.c
index d518102..647ab49 100644
--- a/x86/vmx.c
+++ b/x86/vmx.c
@@ -1486,7 +1486,7 @@ static void test_vmx_caps(void)
report("MSR_IA32_VMX_MISC",
(!(ctrl_cpu_rev[1].clr & CPU_URG) || val & (1ul << 5)) &&
((val >> 16) & 0x1ff) <= 256 &&
- (val & 0xc0007e00) == 0);
+ (val & 0x80007e00) == 0);
for (n = 0; n < ARRAY_SIZE(vmx_ctl_msr); n++) {
ctrl.val = rdmsr(vmx_ctl_msr[n].index);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [kvm-unit-tests PATCH] x86: VMX: MSR_IA32_VMX_MISC[30] is not MBZ
2019-10-02 18:11 [kvm-unit-tests PATCH] x86: VMX: MSR_IA32_VMX_MISC[30] is not MBZ Nadav Amit
@ 2019-10-03 15:23 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2019-10-03 15:23 UTC (permalink / raw)
To: Nadav Amit; +Cc: kvm, sean.j.christopherson
On 02/10/19 20:11, Nadav Amit wrote:
> MSR_IA32_VMX_MISC[30] tells whehter "VM entry allows injection of a
> software interrupt, software exception, or privileged software exception
> with an instruction length of 0".
>
> In other words, it is not MBZ (must be zero), so do not check that it is
> cleared.
>
> Signed-off-by: Nadav Amit <namit@vmware.com>
> ---
> x86/vmx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/x86/vmx.c b/x86/vmx.c
> index d518102..647ab49 100644
> --- a/x86/vmx.c
> +++ b/x86/vmx.c
> @@ -1486,7 +1486,7 @@ static void test_vmx_caps(void)
> report("MSR_IA32_VMX_MISC",
> (!(ctrl_cpu_rev[1].clr & CPU_URG) || val & (1ul << 5)) &&
> ((val >> 16) & 0x1ff) <= 256 &&
> - (val & 0xc0007e00) == 0);
> + (val & 0x80007e00) == 0);
>
> for (n = 0; n < ARRAY_SIZE(vmx_ctl_msr); n++) {
> ctrl.val = rdmsr(vmx_ctl_msr[n].index);
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-03 15:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-02 18:11 [kvm-unit-tests PATCH] x86: VMX: MSR_IA32_VMX_MISC[30] is not MBZ Nadav Amit
2019-10-03 15:23 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox