Re: [kvm-unit-tests PATCH] x86: VMX: MSR_IA32_VMX_MISC[30] is not MBZ

Paolo Bonzini
2019-10-03T15:23:13Z

On 02/10/19 20:11, Nadav Amit wrote:
> MSR_IA32_VMX_MISC[30] tells whehter "VM entry allows injection of a
> software interrupt, software exception, or privileged software exception
> with an instruction length of 0".
>
> In other words, it is not MBZ (must be zero), so do not check that it is
> cleared.
>
> Signed-off-by: Nadav Amit <namit@vmware.com>
> ---
> x86/vmx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/x86/vmx.c b/x86/vmx.c
> index d518102..647ab49 100644
> --- a/x86/vmx.c
> +++ b/x86/vmx.c
> @@ -1486,7 +1486,7 @@ static void test_vmx_caps(void)
> report("MSR_IA32_VMX_MISC",
> (!(ctrl_cpu_rev[1].clr & CPU_URG) || val & (1ul << 5)) &&
> ((val >> 16) & 0x1ff) <= 256 &&
> - (val & 0xc0007e00) == 0);
> + (val & 0x80007e00) == 0);
>
> for (n = 0; n < ARRAY_SIZE(vmx_ctl_msr); n++) {
> ctrl.val = rdmsr(vmx_ctl_msr[n].index);
>

Queued, thanks.

Paolo