* [PATCH kvm-unit-tests] svm: Fixed error code comparison in test npt_rsvd_pfwalk
@ 2019-10-03 12:38 Cathy Avery
2019-10-03 15:23 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Cathy Avery @ 2019-10-03 12:38 UTC (permalink / raw)
To: kvm, pbonzini
According to the AMD64 spec Bit 3 (RSV) in exitinfo1 should be set
to 1 if reserved bits were set in the corresponding nested page
table entry. Exitinfo1 should be checking against error code
0x20000000eULL not 0x200000006ULL.
Signed-off-by: Cathy Avery <cavery@redhat.com>
---
x86/svm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/x86/svm.c b/x86/svm.c
index bc74e7c..bb39934 100644
--- a/x86/svm.c
+++ b/x86/svm.c
@@ -1066,7 +1066,7 @@ static bool npt_rsvd_pfwalk_check(struct test *test)
pdpe[0] &= ~(1ULL << 8);
return (test->vmcb->control.exit_code == SVM_EXIT_NPF)
- && (test->vmcb->control.exit_info_1 == 0x200000006ULL);
+ && (test->vmcb->control.exit_info_1 == 0x20000000eULL);
}
static void npt_l1mmio_prepare(struct test *test)
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH kvm-unit-tests] svm: Fixed error code comparison in test npt_rsvd_pfwalk
2019-10-03 12:38 [PATCH kvm-unit-tests] svm: Fixed error code comparison in test npt_rsvd_pfwalk Cathy Avery
@ 2019-10-03 15:23 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2019-10-03 15:23 UTC (permalink / raw)
To: Cathy Avery, kvm
On 03/10/19 14:38, Cathy Avery wrote:
> According to the AMD64 spec Bit 3 (RSV) in exitinfo1 should be set
> to 1 if reserved bits were set in the corresponding nested page
> table entry. Exitinfo1 should be checking against error code
> 0x20000000eULL not 0x200000006ULL.
>
> Signed-off-by: Cathy Avery <cavery@redhat.com>
> ---
> x86/svm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/x86/svm.c b/x86/svm.c
> index bc74e7c..bb39934 100644
> --- a/x86/svm.c
> +++ b/x86/svm.c
> @@ -1066,7 +1066,7 @@ static bool npt_rsvd_pfwalk_check(struct test *test)
> pdpe[0] &= ~(1ULL << 8);
>
> return (test->vmcb->control.exit_code == SVM_EXIT_NPF)
> - && (test->vmcb->control.exit_info_1 == 0x200000006ULL);
> + && (test->vmcb->control.exit_info_1 == 0x20000000eULL);
> }
>
> static void npt_l1mmio_prepare(struct test *test)
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-03 15:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-03 12:38 [PATCH kvm-unit-tests] svm: Fixed error code comparison in test npt_rsvd_pfwalk Cathy Avery
2019-10-03 15:23 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox