From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C1D8FA372A for ; Wed, 16 Oct 2019 10:18:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5CA3B218DE for ; Wed, 16 Oct 2019 10:18:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389246AbfJPKSM (ORCPT ); Wed, 16 Oct 2019 06:18:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44824 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729316AbfJPKSM (ORCPT ); Wed, 16 Oct 2019 06:18:12 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 157B8316D8C8; Wed, 16 Oct 2019 10:18:12 +0000 (UTC) Received: from gondolin (dhcp-192-233.str.redhat.com [10.33.192.233]) by smtp.corp.redhat.com (Postfix) with ESMTP id D5FBE60852; Wed, 16 Oct 2019 10:18:10 +0000 (UTC) Date: Wed, 16 Oct 2019 12:17:48 +0200 From: Cornelia Huck To: Eric Farman Cc: Steffen Maier , Halil Pasic , Jason Herne , Jared Rossi , linux-s390@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v2 4/4] vfio-ccw: Rework the io_fctl trace Message-ID: <20191016121748.7982cb24.cohuck@redhat.com> In-Reply-To: <20191016015822.72425-5-farman@linux.ibm.com> References: <20191016015822.72425-1-farman@linux.ibm.com> <20191016015822.72425-5-farman@linux.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Wed, 16 Oct 2019 10:18:12 +0000 (UTC) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, 16 Oct 2019 03:58:22 +0200 Eric Farman wrote: > Using __field_struct for the schib is convenient, but it doesn't > appear to let us filter based on any of the schib elements. > Specifying, the full schid or any element within it results s/Specifying,/Specifying/ > in various errors by the parser. So, expand that out to its > component elements, so we can limit the trace to a single device. > > While we are at it, rename this trace to the function name, so we > remember what is being traced instead of an abstract reference to the > function control bit of the SCSW. > > Signed-off-by: Eric Farman > --- > drivers/s390/cio/vfio_ccw_fsm.c | 4 ++-- > drivers/s390/cio/vfio_ccw_trace.c | 2 +- > drivers/s390/cio/vfio_ccw_trace.h | 18 +++++++++++------- > 3 files changed, 14 insertions(+), 10 deletions(-) Reviewed-by: Cornelia Huck