From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F378CA9EAF for ; Thu, 24 Oct 2019 20:21:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 28FCF21A4C for ; Thu, 24 Oct 2019 20:21:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727338AbfJXUVh (ORCPT ); Thu, 24 Oct 2019 16:21:37 -0400 Received: from mga09.intel.com ([134.134.136.24]:5516 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725958AbfJXUVh (ORCPT ); Thu, 24 Oct 2019 16:21:37 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2019 13:21:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,226,1569308400"; d="scan'208";a="202408345" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.41]) by orsmga006.jf.intel.com with ESMTP; 24 Oct 2019 13:21:36 -0700 Date: Thu, 24 Oct 2019 13:21:36 -0700 From: Sean Christopherson To: Jim Mattson Cc: kvm@vger.kernel.org, Paolo Bonzini , Ken Hofsass , Peter Shier Subject: Re: [PATCH v2] kvm: x86: Add cr3 to struct kvm_debug_exit_arch Message-ID: <20191024202136.GC28043@linux.intel.com> References: <20191024195431.183667-1-jmattson@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191024195431.183667-1-jmattson@google.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Oct 24, 2019 at 12:54:31PM -0700, Jim Mattson wrote: > From: Ken Hofsass > > A userspace agent can use cr3 to quickly determine whether a > KVM_EXIT_DEBUG is associated with a guest process of interest. > > KVM_CAP_DEBUG_EVENT_PDBR indicates support for the extension. Isn't PDBR x86-specific terminology? If we're going to use something that is x86-specific then just call it GUEST_CR3. If there's a chance that this is useful on other architectures then it'd probably be better to go with Linux's own terminology, e.g. KVM_CAP_DEBUG_EVENT_GUEST_PGD. > Signed-off-by: Ken Hofsass > Signed-off-by: Jim Mattson > Cc: Peter Shier > --- > v1 -> v2: Changed KVM_CAP_DEBUG_EVENT_PG_BASE_ADDR to KVM_CAP_DEBUG_EVENT_PDBR > Set debug.arch.cr3 in kvm_vcpu_do_singlestep and > kvm_vcpu_check_breakpoint > Added svm support Heh, I wonder what the record is for longest time between legitimate versions of a single patch.