From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C5EBCA9ECF for ; Fri, 1 Nov 2019 14:58:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E59EE20650 for ; Fri, 1 Nov 2019 14:57:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727873AbfKAO57 (ORCPT ); Fri, 1 Nov 2019 10:57:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47284 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727365AbfKAO56 (ORCPT ); Fri, 1 Nov 2019 10:57:58 -0400 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B99D981F01 for ; Fri, 1 Nov 2019 14:57:57 +0000 (UTC) Received: by mail-wr1-f71.google.com with SMTP id f4so5630736wrj.12 for ; Fri, 01 Nov 2019 07:57:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mxbhV/T/CvsMOMyGYwlWuXmCgdmHOLkaW1oOJvRLs5U=; b=sBuaJeFVHnC2sY86APNK45QOjvoC2suNlzEsorZSF13jWisySnedIgGYI31u5kuVEV X7ta6Unr0r4KzeyJsg27H2rLeuwY1Z/T7xw6p68pyu1e1ognM0rhPOqJQ8i7cuXFJp9m 11aCrQ+rbBm0SixnSuSYAzJCXetN+SpNkdJLX/kUpSETwffFjLm0P+qbGttstu2K6zJZ HNgB4DAvk1J6LwHFbV/usSG0l4um1gs0yBfZZgSqWoSseQpBCGckJYCJrIxfr2GszdAk Rm2kAg3lWmg33g4WDbprzyEvOcEnHaI5cVycQyvrtg1KKbaDv70gOBTBcyLYvWEbDu/H BoCg== X-Gm-Message-State: APjAAAUsX+hGXyGl1o7KXgGROCgosi/8bTGgJU77CJySHnR+w1dgQI0q RnoUPAsAsW/fsad3V36HtmJ0Kx3mAfoBhKV+Uf0KP+647EwK0kf0/PkvIbb7AS1yyHSIIoEKDjr 5Ui0IH/fILX1p X-Received: by 2002:adf:9dca:: with SMTP id q10mr11007747wre.183.1572620276514; Fri, 01 Nov 2019 07:57:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqy3RPaeRKKYjy99njnTtrRhDleSomhc57v9Y+qUEuftHEy0zp6kpuXrxOSkCRCWs1qec44ivA== X-Received: by 2002:adf:9dca:: with SMTP id q10mr11007730wre.183.1572620276332; Fri, 01 Nov 2019 07:57:56 -0700 (PDT) Received: from xz-x1.metropole.lan ([91.217.168.176]) by smtp.gmail.com with ESMTPSA id y1sm7962105wrw.6.2019.11.01.07.57.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Nov 2019 07:57:55 -0700 (PDT) Date: Fri, 1 Nov 2019 15:57:53 +0100 From: Peter Xu To: Liu Yi L Cc: qemu-devel@nongnu.org, mst@redhat.com, pbonzini@redhat.com, alex.williamson@redhat.com, eric.auger@redhat.com, david@gibson.dropbear.id.au, tianyu.lan@intel.com, kevin.tian@intel.com, jun.j.tian@intel.com, yi.y.sun@intel.com, jacob.jun.pan@linux.intel.com, kvm@vger.kernel.org, Yi Sun Subject: Re: [RFC v2 03/22] intel_iommu: modify x-scalable-mode to be string option Message-ID: <20191101145753.GC8888@xz-x1.metropole.lan> References: <1571920483-3382-1-git-send-email-yi.l.liu@intel.com> <1571920483-3382-4-git-send-email-yi.l.liu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1571920483-3382-4-git-send-email-yi.l.liu@intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Oct 24, 2019 at 08:34:24AM -0400, Liu Yi L wrote: > Intel VT-d 3.0 introduces scalable mode, and it has a bunch of capabilities > related to scalable mode translation, thus there are multiple combinations. > While this vIOMMU implementation wants simplify it for user by providing > typical combinations. User could config it by "x-scalable-mode" option. The > usage is as below: > > "-device intel-iommu,x-scalable-mode=["legacy"|"modern"]" > > - "legacy": gives support for SL page table > - "modern": gives support for FL page table, pasid, virtual command > - if not configured, means no scalable mode support, if not proper > configured, will throw error > > Cc: Kevin Tian > Cc: Jacob Pan > Cc: Peter Xu > Cc: Yi Sun > Signed-off-by: Liu Yi L > Signed-off-by: Yi Sun > --- > hw/i386/intel_iommu.c | 15 +++++++++++++-- > hw/i386/intel_iommu_internal.h | 3 +++ > include/hw/i386/intel_iommu.h | 2 +- > 3 files changed, 17 insertions(+), 3 deletions(-) > > diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c > index 771bed2..4a1a07a 100644 > --- a/hw/i386/intel_iommu.c > +++ b/hw/i386/intel_iommu.c > @@ -3019,7 +3019,7 @@ static Property vtd_properties[] = { > DEFINE_PROP_UINT8("aw-bits", IntelIOMMUState, aw_bits, > VTD_HOST_ADDRESS_WIDTH), > DEFINE_PROP_BOOL("caching-mode", IntelIOMMUState, caching_mode, FALSE), > - DEFINE_PROP_BOOL("x-scalable-mode", IntelIOMMUState, scalable_mode, FALSE), > + DEFINE_PROP_STRING("x-scalable-mode", IntelIOMMUState, scalable_mode), > DEFINE_PROP_BOOL("dma-drain", IntelIOMMUState, dma_drain, true), > DEFINE_PROP_END_OF_LIST(), > }; > @@ -3581,7 +3581,12 @@ static void vtd_init(IntelIOMMUState *s) > > /* TODO: read cap/ecap from host to decide which cap to be exposed. */ > if (s->scalable_mode) { > - s->ecap |= VTD_ECAP_SMTS | VTD_ECAP_SRS | VTD_ECAP_SLTS; > + if (!strcmp(s->scalable_mode, "legacy")) { > + s->ecap |= VTD_ECAP_SMTS | VTD_ECAP_SRS | VTD_ECAP_SLTS; > + } else if (!strcmp(s->scalable_mode, "modern")) { > + s->ecap |= VTD_ECAP_SMTS | VTD_ECAP_SRS | VTD_ECAP_PASID > + | VTD_ECAP_FLTS | VTD_ECAP_PSS; > + } Shall we do this string op only once in vtd_decide_config() then keep it somewhere? Something like: - s->scalable_mode_str to keep the string - s->scalable_mode still as a bool to cache the global enablement - s->scalable_modern as a bool to keep the mode ? These could be used in some MMIO path (I think) and parsing strings always could be a bit overkill. > } > > vtd_reset_caches(s); > @@ -3700,6 +3705,12 @@ static bool vtd_decide_config(IntelIOMMUState *s, Error **errp) > return false; > } > > + if (s->scalable_mode && > + (strcmp(s->scalable_mode, "modern") && > + strcmp(s->scalable_mode, "legacy"))) { > + error_setg(errp, "Invalid x-scalable-mode config"); > + } > + > return true; > } > > diff --git a/hw/i386/intel_iommu_internal.h b/hw/i386/intel_iommu_internal.h > index c1235a7..be7b30a 100644 > --- a/hw/i386/intel_iommu_internal.h > +++ b/hw/i386/intel_iommu_internal.h > @@ -190,8 +190,11 @@ > #define VTD_ECAP_PT (1ULL << 6) > #define VTD_ECAP_MHMV (15ULL << 20) > #define VTD_ECAP_SRS (1ULL << 31) > +#define VTD_ECAP_PSS (19ULL << 35) > +#define VTD_ECAP_PASID (1ULL << 40) > #define VTD_ECAP_SMTS (1ULL << 43) > #define VTD_ECAP_SLTS (1ULL << 46) > +#define VTD_ECAP_FLTS (1ULL << 47) > > /* CAP_REG */ > /* (offset >> 4) << 24 */ > diff --git a/include/hw/i386/intel_iommu.h b/include/hw/i386/intel_iommu.h > index 66b931e..6062588 100644 > --- a/include/hw/i386/intel_iommu.h > +++ b/include/hw/i386/intel_iommu.h > @@ -231,7 +231,7 @@ struct IntelIOMMUState { > uint32_t version; > > bool caching_mode; /* RO - is cap CM enabled? */ > - bool scalable_mode; /* RO - is Scalable Mode supported? */ > + char *scalable_mode; /* RO - Scalable Mode model */ > > dma_addr_t root; /* Current root table pointer */ > bool root_scalable; /* Type of root table (scalable or not) */ > -- > 2.7.4 > Regards, -- Peter Xu