Re: [PATCH net-next 09/19] vfio/mdev: Expose mdev alias in sysfs tree

Jiri Pirko
2019-11-08T13:22:35Z

Thu, Nov 07, 2019 at 05:08:24PM CET, parav@mellanox.com wrote:

[...]

>
>+static ssize_t alias_show(struct device *device,
>+ struct device_attribute *attr, char *buf)
>+{
>+ struct mdev_device *dev = mdev_from_dev(device);
>+
>+ if (!dev->alias)
>+ return -EOPNOTSUPP;
>+
>+ return sprintf(buf, "%s\n", dev->alias);
>+}
>+static DEVICE_ATTR_RO(alias);

I wonder, rather than adding another sysfs file, why the alias can't be
simply a symlink to the aliased mdev directory?

>+
> static const struct attribute *mdev_device_attrs[] = {
>+ &dev_attr_alias.attr,
> &dev_attr_remove.attr,
> NULL,
> };
>--
>2.19.2
>