Re: [kvm-unit-tests PATCH v2 0/3] s390x: Improve architectural compliance for diag308

David Hildenbrand
2019-11-12T12:10:43Z

On 11.11.19 16:33, Janosch Frank wrote:
> When testing diag308 subcodes 0/1 on lpar with virtual mem set up, I
> experienced spec PGMs and addressing PGMs due to the tests not setting
> short psw bit 12 and leaving the DAT bit on. The problem was not found
> under KVM/QEMU, because Qemu just ignores all cpu mask bits.
>
> v1 -> v2:
> * Fixed comment in extra patch
> * Now using pre-defined reset psw
> * Fixed some comments
>
> Janosch Frank (3):
> s390x: Fix initial cr0 load comments
> s390x: Add CR save area
> s390x: Load reset psw on diag308 reset
>
> lib/s390x/asm-offsets.c | 3 ++-
> lib/s390x/asm/arch_def.h | 5 +++--
> lib/s390x/interrupt.c | 4 ++--
> lib/s390x/smp.c | 2 +-
> s390x/cstart64.S | 38 ++++++++++++++++++++++++--------------
> 5 files changed, 32 insertions(+), 20 deletions(-)
>

I'll queue the first two patches for now to

https://github.com/davidhildenbrand/kvm-unit-tests.git s390x-next

And wait with the first until we know if it's a TCG or a kvm-unit-tests
bug that makes the SMP test fail.

--

Thanks,

David / dhildenb