From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BCB3C432C0 for ; Fri, 22 Nov 2019 01:35:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D6B93206C2 for ; Fri, 22 Nov 2019 01:35:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.b="gW3Hi0pZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726546AbfKVBfp (ORCPT ); Thu, 21 Nov 2019 20:35:45 -0500 Received: from bilbo.ozlabs.org ([203.11.71.1]:47539 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726265AbfKVBfo (ORCPT ); Thu, 21 Nov 2019 20:35:44 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 47JzXG0jZgz9sPc; Fri, 22 Nov 2019 12:35:42 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1574386542; bh=62P9Bw5+9to0Slr+T/14kFaeF/kxhz6hpAJVGFKmB3I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gW3Hi0pZd5YlQeQ2JtADeu5stdmyNVtqHXdykkR84iKdCeF9bwoWzGP66j0UpAk1s eVjYPbMA4t4MCf6t0BF7clFZZhF1A80SFpI3i/dwAJxN0wJAwGp+GWdxyp4bOEzxi+ 4cPGAdF80yqWT4sPl6JdLrB/Ln5EZPnYhA08MU7U= Date: Fri, 22 Nov 2019 12:35:37 +1100 From: David Gibson To: Alex Williamson Cc: clg@kaod.org, groug@kaod.org, philmd@redhat.com, qemu-ppc@nongnu.org, Paolo Bonzini , Jason Wang , Laurent Vivier , kvm@vger.kernel.org, qemu-devel@nongnu.org, Riku Voipio , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau Subject: Re: [PATCH 0/5] vfio/spapr: Handle changes of master irq chip for VFIO devices Message-ID: <20191122013537.GY5582@umbus.fritz.box> References: <20191121005607.274347-1-david@gibson.dropbear.id.au> <20191121095738.71f90700@x1.home> <20191122011824.GX5582@umbus.fritz.box> <20191121182807.51caac33@x1.home> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="j3eaMWZhMWMo+sdM" Content-Disposition: inline In-Reply-To: <20191121182807.51caac33@x1.home> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org --j3eaMWZhMWMo+sdM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 21, 2019 at 06:28:07PM -0700, Alex Williamson wrote: > On Fri, 22 Nov 2019 12:18:24 +1100 > David Gibson wrote: >=20 > > On Thu, Nov 21, 2019 at 09:57:38AM -0700, Alex Williamson wrote: > > > On Thu, 21 Nov 2019 11:56:02 +1100 > > > David Gibson wrote: > > > =20 > > > > Due to the way feature negotiation works in PAPR (which is a > > > > paravirtualized platform), we can end up changing the global irq ch= ip > > > > at runtime, including it's KVM accelerate model. That causes > > > > complications for VFIO devices with INTx, which wire themselves up > > > > directly to the KVM irqchip for performance. > > > >=20 > > > > This series introduces a new notifier to let VFIO devices (and > > > > anything else that needs to in the future) know about changes to the > > > > master irqchip. It modifies VFIO to respond to the notifier, > > > > reconnecting itself to the new KVM irqchip as necessary. > > > >=20 > > > > In particular this removes a misleading (though not wholly inaccura= te) > > > > warning that occurs when using VFIO devices on a pseries machine ty= pe > > > > guest. > > > >=20 > > > > Open question: should this go into qemu-4.2 or wait until 5.0? It's > > > > has medium complexity / intrusiveness, but it *is* a bugfix that I > > > > can't see a simpler way to fix. It's effectively a regression from > > > > qemu-4.0 to qemu-4.1 (because that introduced XIVE support by > > > > default), although not from 4.1 to 4.2. =20 > > >=20 > > > Looks reasonable to me for 4.2, the vfio changes are not as big as th= ey > > > appear. If Paolo approves this week, I can send a pull request, > > > otherwise I can leave my ack for someone else as I'll be on PTO/holid= ay > > > next week. Thanks, =20 > >=20 > > I'm happy to take it through my tree, and expect to be sending a PR in > > that timescale, so an ack sounds good. > >=20 > > I've pulled the series into my ppc-for-4.2 branch tentatively. >=20 > Tested-by: Alex Williamson > Reviewed-by: Alex Williamson > Acked-by: Alex Williamson Thanks! --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --j3eaMWZhMWMo+sdM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAl3XO2kACgkQbDjKyiDZ s5J/KhAAm+OyfNei3T30mvYb2KiFzebufX6Ppyn3E5awnxLa0HbyUvp4SGFyo6cy CtSee6Cme6LRat/X3i4ko2YVanig06Gbvm7QKH0uIiHqDdibCZKpJfOj3je2rRRr 1xUXcrbJhlkb56lra+baLdcuc0WjQWTVM3eovIX/nGGDyfhIzRkzlGylDVR/4hpT VpgS/n0KFqXPm+nK+5YlDersGh2KjRa4r9e8s3EkmPuvh52p6WJlQwit7zEbRq6X cfg9SBXgQYYf95k5WZxnwiffEdfscxzZexvTYKClFZpJhwhCQXlnt9s1fytbh+al 1zdwShhq0WjiP95XxMnUrMaxCls667o3OU6UF2l7DPAA1lDAtwntxkz8LFhDggMN uLOOYSr3bD4TQvWYoaIMdAIuj3dT2zte3eaVfij937RwwzRJJubHl15YCHVkIW3X ahWBcsx3s/jYqyx9jcN6avqk0Df6YCZeJSBCM0QxsSMSBMHNC4ZzkhoBdYPgAjHc 8X5ME5pN8Pq/l8S6YXMeHBZaoSkklN+8Pmd7QZG2XjSW6+r9fmMWWnHXSX797JSy 32mERsXgRjyqwRANUniJxPbqTIhGVy7VzscxW05ne4DkmHpfAT043rLcn5gHJplS Y+BrLlM/FLydyVNREE+LWiDm6P8/IGEY7t/r8RoqmUt6bnbn9bk= =T3fw -----END PGP SIGNATURE----- --j3eaMWZhMWMo+sdM--