From: Joerg Roedel <joro@8bytes.org>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Andrea Arcangeli" <aarcange@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
kvm@vger.kernel.org
Subject: Re: THP refcounting in disallowed_hugepage_adjust()?
Date: Wed, 27 Nov 2019 10:41:40 +0100 [thread overview]
Message-ID: <20191127094140.GA11039@8bytes.org> (raw)
In-Reply-To: <20191126174603.GB22233@linux.intel.com>
Hi Jean,
On Tue, Nov 26, 2019 at 09:46:03AM -0800, Sean Christopherson wrote:
> disallowed_hugepage_adjust() is called from __direct_map() and its
> modification of the pfn is also contained to __direct_map(), i.e. the
> updated @pfn doesn't get propagated back up to the fault handlers. Thus,
> kvm_release_pfn_clean() is called on the original pfn and so there's no
> need to transfer the page reference.
Thanks for your explanation, makes a lot of sense to me now.
Regards,
Joerg
prev parent reply other threads:[~2019-11-27 9:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 15:21 THP refcounting in disallowed_hugepage_adjust()? Joerg Roedel
2019-11-26 17:46 ` Sean Christopherson
2019-11-27 9:41 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191127094140.GA11039@8bytes.org \
--to=joro@8bytes.org \
--cc=aarcange@redhat.com \
--cc=kirill@shutemov.name \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).