From: Jiang Yi <giangyi@amazon.com>
To: kvm@vger.kernel.org
Cc: adulea@amazon.de, jschoenh@amazon.de, maz@kernel.org,
alex.williamson@redhat.com, cohuck@redhat.com,
Jiang Yi <giangyi@amazon.com>
Subject: [PATCH] vfio: call irq_bypass_unregister_producer() before freeing irq
Date: Wed, 27 Nov 2019 17:49:10 +0100 [thread overview]
Message-ID: <20191127164910.15888-1-giangyi@amazon.com> (raw)
Since irq_bypass_register_producer() is called after request_irq(), we
should do tear-down in reverse order: irq_bypass_unregister_producer()
then free_irq().
Signed-off-by: Jiang Yi <giangyi@amazon.com>
---
drivers/vfio/pci/vfio_pci_intrs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c
index 3fa3f728fb39..2056f3f85f59 100644
--- a/drivers/vfio/pci/vfio_pci_intrs.c
+++ b/drivers/vfio/pci/vfio_pci_intrs.c
@@ -289,18 +289,18 @@ static int vfio_msi_set_vector_signal(struct vfio_pci_device *vdev,
int irq, ret;
if (vector < 0 || vector >= vdev->num_ctx)
return -EINVAL;
irq = pci_irq_vector(pdev, vector);
if (vdev->ctx[vector].trigger) {
- free_irq(irq, vdev->ctx[vector].trigger);
irq_bypass_unregister_producer(&vdev->ctx[vector].producer);
+ free_irq(irq, vdev->ctx[vector].trigger);
kfree(vdev->ctx[vector].name);
eventfd_ctx_put(vdev->ctx[vector].trigger);
vdev->ctx[vector].trigger = NULL;
}
if (fd < 0)
return 0;
--
2.17.1
next reply other threads:[~2019-11-27 16:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 16:49 Jiang Yi [this message]
2019-11-27 18:20 ` [PATCH] vfio: call irq_bypass_unregister_producer() before freeing irq Marc Zyngier
2019-12-02 23:14 ` Alex Williamson
2019-11-28 10:01 ` Auger Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191127164910.15888-1-giangyi@amazon.com \
--to=giangyi@amazon.com \
--cc=adulea@amazon.de \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=jschoenh@amazon.de \
--cc=kvm@vger.kernel.org \
--cc=maz@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).