Re: [PATCH RFC 03/15] KVM: Add build-time error check on kvm_run size

Peter Xu
2019-12-03T17:04:43Z

On Tue, Dec 03, 2019 at 02:41:58PM +0100, Paolo Bonzini wrote:
> On 02/12/19 23:19, Sean Christopherson wrote:
> >>> e.g. in a mostly hypothetical case where the allocation of vcpu->run
> >>> were changed to something else.
> >> And that's why I added BUILD_BUG_ON right beneath that allocation. :)
>
> It's not exactly beneath it (it's out of the patch context at least). I
> think a comment is not strictly necessary, but a better commit message
> is and, since you are at it, I would put the BUILD_BUG_ON *before* the
> allocation. That makes it more obvious that you are checking the
> invariant before allocating.

Makes sense, will do. Thanks for both of your reviews.

--
Peter Xu