Re: [kvm-unit-tests PATCH v2 2/9] s390x: Define the PSW bits

David Hildenbrand
2019-11-28T14:36:38Z

On 28.11.19 13:46, Pierre Morel wrote:
> Let's define the PSW bits explicitly, it will clarify their
> usage.
>
> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
> ---
> lib/s390x/asm/arch_bits.h | 20 ++++++++++++++++++++
> lib/s390x/asm/arch_def.h | 6 ++----

I'm sorry, but I don't really see a reason to move these 4/5 defines to
a separate header. Can you just keep them in arch_def.h and extend?

(none of your other patches touch arch_bits.h - and it is somewhat a
weird name. Where to put something new: arch_def.h or arch_bits.h? I
would have understood "psw.h", but even that, I don't consider necessary)

--
Thanks,

David / dhildenb