Re: [kvm-unit-tests PATCH v2 2/9] s390x: Define the PSW bits

David Hildenbrand
2019-12-02T11:17:26Z

On 02.12.19 12:11, Janosch Frank wrote:
> On 11/28/19 3:36 PM, David Hildenbrand wrote:
>> On 28.11.19 13:46, Pierre Morel wrote:
>>> Let's define the PSW bits explicitly, it will clarify their
>>> usage.
>>>
>>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>>> ---
>>> lib/s390x/asm/arch_bits.h | 20 ++++++++++++++++++++
>>> lib/s390x/asm/arch_def.h | 6 ++----
>>
>> I'm sorry, but I don't really see a reason to move these 4/5 defines to
>> a separate header. Can you just keep them in arch_def.h and extend?
>>
>> (none of your other patches touch arch_bits.h - and it is somewhat a
>> weird name. Where to put something new: arch_def.h or arch_bits.h? I
>> would have understood "psw.h", but even that, I don't consider necessary)
>>
>
> On a related note:
> I'd still like to split up the file soonish, maybe moving the functions
> into a new file?
>
> @Thomas/David: What's your opinion on that?

Sure, as long as the file header is not longer as its actual content :D

--
Thanks,

David / dhildenb