* [PATCH] KVM: s390: ENOTSUPP -> EOPNOTSUPP fixups
@ 2019-12-05 12:51 Christian Borntraeger
2019-12-05 13:05 ` Cornelia Huck
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Christian Borntraeger @ 2019-12-05 12:51 UTC (permalink / raw)
To: Janosch Frank
Cc: KVM, Cornelia Huck, Christian Borntraeger, David Hildenbrand,
linux-s390, Thomas Huth, Julian Wiedmann
There is no ENOTSUPP for userspace
Reported-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
arch/s390/kvm/interrupt.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
index 2a711bae69a7..bd9b339bbb5e 100644
--- a/arch/s390/kvm/interrupt.c
+++ b/arch/s390/kvm/interrupt.c
@@ -2312,7 +2312,7 @@ static int flic_ais_mode_get_all(struct kvm *kvm, struct kvm_device_attr *attr)
return -EINVAL;
if (!test_kvm_facility(kvm, 72))
- return -ENOTSUPP;
+ return -EOPNOTSUPP;
mutex_lock(&fi->ais_lock);
ais.simm = fi->simm;
@@ -2621,7 +2621,7 @@ static int modify_ais_mode(struct kvm *kvm, struct kvm_device_attr *attr)
int ret = 0;
if (!test_kvm_facility(kvm, 72))
- return -ENOTSUPP;
+ return -EOPNOTSUPP;
if (copy_from_user(&req, (void __user *)attr->addr, sizeof(req)))
return -EFAULT;
@@ -2701,7 +2701,7 @@ static int flic_ais_mode_set_all(struct kvm *kvm, struct kvm_device_attr *attr)
struct kvm_s390_ais_all ais;
if (!test_kvm_facility(kvm, 72))
- return -ENOTSUPP;
+ return -EOPNOTSUPP;
if (copy_from_user(&ais, (void __user *)attr->addr, sizeof(ais)))
return -EFAULT;
--
2.24.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] KVM: s390: ENOTSUPP -> EOPNOTSUPP fixups
2019-12-05 12:51 [PATCH] KVM: s390: ENOTSUPP -> EOPNOTSUPP fixups Christian Borntraeger
@ 2019-12-05 13:05 ` Cornelia Huck
2019-12-05 13:09 ` Thomas Huth
2019-12-05 14:50 ` Christian Borntraeger
2 siblings, 0 replies; 7+ messages in thread
From: Cornelia Huck @ 2019-12-05 13:05 UTC (permalink / raw)
To: Christian Borntraeger
Cc: Janosch Frank, KVM, David Hildenbrand, linux-s390, Thomas Huth,
Julian Wiedmann
On Thu, 5 Dec 2019 13:51:47 +0100
Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> There is no ENOTSUPP for userspace
s/userspace/userspace./
Fixes: 519783935451 ("KVM: s390: introduce ais mode modify function")
Fixes: 2c1a48f2e5ed ("KVM: S390: add new group for flic")
>
> Reported-by: Julian Wiedmann <jwi@linux.ibm.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> arch/s390/kvm/interrupt.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] KVM: s390: ENOTSUPP -> EOPNOTSUPP fixups
2019-12-05 12:51 [PATCH] KVM: s390: ENOTSUPP -> EOPNOTSUPP fixups Christian Borntraeger
2019-12-05 13:05 ` Cornelia Huck
@ 2019-12-05 13:09 ` Thomas Huth
2019-12-05 13:16 ` Christian Borntraeger
2019-12-05 14:50 ` Christian Borntraeger
2 siblings, 1 reply; 7+ messages in thread
From: Thomas Huth @ 2019-12-05 13:09 UTC (permalink / raw)
To: Christian Borntraeger, Janosch Frank
Cc: KVM, Cornelia Huck, David Hildenbrand, linux-s390,
Julian Wiedmann
On 05/12/2019 13.51, Christian Borntraeger wrote:
> There is no ENOTSUPP for userspace
>
> Reported-by: Julian Wiedmann <jwi@linux.ibm.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> arch/s390/kvm/interrupt.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
> index 2a711bae69a7..bd9b339bbb5e 100644
> --- a/arch/s390/kvm/interrupt.c
> +++ b/arch/s390/kvm/interrupt.c
> @@ -2312,7 +2312,7 @@ static int flic_ais_mode_get_all(struct kvm *kvm, struct kvm_device_attr *attr)
> return -EINVAL;
>
> if (!test_kvm_facility(kvm, 72))
> - return -ENOTSUPP;
> + return -EOPNOTSUPP;
>
> mutex_lock(&fi->ais_lock);
> ais.simm = fi->simm;
> @@ -2621,7 +2621,7 @@ static int modify_ais_mode(struct kvm *kvm, struct kvm_device_attr *attr)
> int ret = 0;
>
> if (!test_kvm_facility(kvm, 72))
> - return -ENOTSUPP;
> + return -EOPNOTSUPP;
>
> if (copy_from_user(&req, (void __user *)attr->addr, sizeof(req)))
> return -EFAULT;
> @@ -2701,7 +2701,7 @@ static int flic_ais_mode_set_all(struct kvm *kvm, struct kvm_device_attr *attr)
> struct kvm_s390_ais_all ais;
>
> if (!test_kvm_facility(kvm, 72))
> - return -ENOTSUPP;
> + return -EOPNOTSUPP;
>
> if (copy_from_user(&ais, (void __user *)attr->addr, sizeof(ais)))
> return -EFAULT;
>
Good catch.
Reviewed-by: Thomas Huth <thuth@redhat.com>
There seems to be another one in arch/s390/include/asm/uv.h, are you
going to fix that, too?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] KVM: s390: ENOTSUPP -> EOPNOTSUPP fixups
2019-12-05 13:09 ` Thomas Huth
@ 2019-12-05 13:16 ` Christian Borntraeger
2019-12-05 16:09 ` Heiko Carstens
0 siblings, 1 reply; 7+ messages in thread
From: Christian Borntraeger @ 2019-12-05 13:16 UTC (permalink / raw)
To: Thomas Huth, Janosch Frank
Cc: KVM, Cornelia Huck, David Hildenbrand, linux-s390,
Julian Wiedmann
On 05.12.19 14:09, Thomas Huth wrote:
> On 05/12/2019 13.51, Christian Borntraeger wrote:
>> There is no ENOTSUPP for userspace
>>
>> Reported-by: Julian Wiedmann <jwi@linux.ibm.com>
>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> ---
>> arch/s390/kvm/interrupt.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
>> index 2a711bae69a7..bd9b339bbb5e 100644
>> --- a/arch/s390/kvm/interrupt.c
>> +++ b/arch/s390/kvm/interrupt.c
>> @@ -2312,7 +2312,7 @@ static int flic_ais_mode_get_all(struct kvm *kvm, struct kvm_device_attr *attr)
>> return -EINVAL;
>>
>> if (!test_kvm_facility(kvm, 72))
>> - return -ENOTSUPP;
>> + return -EOPNOTSUPP;
>>
>> mutex_lock(&fi->ais_lock);
>> ais.simm = fi->simm;
>> @@ -2621,7 +2621,7 @@ static int modify_ais_mode(struct kvm *kvm, struct kvm_device_attr *attr)
>> int ret = 0;
>>
>> if (!test_kvm_facility(kvm, 72))
>> - return -ENOTSUPP;
>> + return -EOPNOTSUPP;
>>
>> if (copy_from_user(&req, (void __user *)attr->addr, sizeof(req)))
>> return -EFAULT;
>> @@ -2701,7 +2701,7 @@ static int flic_ais_mode_set_all(struct kvm *kvm, struct kvm_device_attr *attr)
>> struct kvm_s390_ais_all ais;
>>
>> if (!test_kvm_facility(kvm, 72))
>> - return -ENOTSUPP;
>> + return -EOPNOTSUPP;
>>
>> if (copy_from_user(&ais, (void __user *)attr->addr, sizeof(ais)))
>> return -EFAULT;
>>
>
> Good catch.
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
> There seems to be another one in arch/s390/include/asm/uv.h, are you
> going to fix that, too?
>
I looked into that but it seemed that this is not exposed to userspace and just kept internal.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] KVM: s390: ENOTSUPP -> EOPNOTSUPP fixups
2019-12-05 13:16 ` Christian Borntraeger
@ 2019-12-05 16:09 ` Heiko Carstens
2019-12-05 17:07 ` Christian Borntraeger
0 siblings, 1 reply; 7+ messages in thread
From: Heiko Carstens @ 2019-12-05 16:09 UTC (permalink / raw)
To: Christian Borntraeger
Cc: Thomas Huth, Janosch Frank, KVM, Cornelia Huck, David Hildenbrand,
linux-s390, Julian Wiedmann, Stefan Haberland, Jan Hoeppner
On Thu, Dec 05, 2019 at 02:16:02PM +0100, Christian Borntraeger wrote:
> On 05.12.19 14:09, Thomas Huth wrote:
> > On 05/12/2019 13.51, Christian Borntraeger wrote:
> >> There is no ENOTSUPP for userspace
> >>
> >> Reported-by: Julian Wiedmann <jwi@linux.ibm.com>
> >> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> >> ---
> >> - return -ENOTSUPP;
> >> + return -EOPNOTSUPP;
> > There seems to be another one in arch/s390/include/asm/uv.h, are you
> > going to fix that, too?
> I looked into that but it seemed that this is not exposed to
> userspace and just kept internal.
Could you remove that one as well, please? Otherwise people start
copy-pasting this (again). I thought we got rid of them all, and now
they crept in again.
Same for dasd ioctl code...
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] KVM: s390: ENOTSUPP -> EOPNOTSUPP fixups
2019-12-05 16:09 ` Heiko Carstens
@ 2019-12-05 17:07 ` Christian Borntraeger
0 siblings, 0 replies; 7+ messages in thread
From: Christian Borntraeger @ 2019-12-05 17:07 UTC (permalink / raw)
To: Heiko Carstens
Cc: Thomas Huth, Janosch Frank, KVM, Cornelia Huck, David Hildenbrand,
linux-s390, Julian Wiedmann, Stefan Haberland, Jan Hoeppner
On 05.12.19 17:09, Heiko Carstens wrote:
> On Thu, Dec 05, 2019 at 02:16:02PM +0100, Christian Borntraeger wrote:
>> On 05.12.19 14:09, Thomas Huth wrote:
>>> On 05/12/2019 13.51, Christian Borntraeger wrote:
>>>> There is no ENOTSUPP for userspace
>>>>
>>>> Reported-by: Julian Wiedmann <jwi@linux.ibm.com>
>>>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>>>> ---
>>>> - return -ENOTSUPP;
>>>> + return -EOPNOTSUPP;
>>> There seems to be another one in arch/s390/include/asm/uv.h, are you
>>> going to fix that, too?
>> I looked into that but it seemed that this is not exposed to
>> userspace and just kept internal.
>
> Could you remove that one as well, please? Otherwise people start
> copy-pasting this (again). I thought we got rid of them all, and now
> they crept in again.
Will do a separate patch as this goes via s390 tree, ok?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] KVM: s390: ENOTSUPP -> EOPNOTSUPP fixups
2019-12-05 12:51 [PATCH] KVM: s390: ENOTSUPP -> EOPNOTSUPP fixups Christian Borntraeger
2019-12-05 13:05 ` Cornelia Huck
2019-12-05 13:09 ` Thomas Huth
@ 2019-12-05 14:50 ` Christian Borntraeger
2 siblings, 0 replies; 7+ messages in thread
From: Christian Borntraeger @ 2019-12-05 14:50 UTC (permalink / raw)
To: Janosch Frank
Cc: KVM, Cornelia Huck, David Hildenbrand, linux-s390, Thomas Huth,
Julian Wiedmann
On 05.12.19 13:51, Christian Borntraeger wrote:
> There is no ENOTSUPP for userspace
>
> Reported-by: Julian Wiedmann <jwi@linux.ibm.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
applied.
> ---
> arch/s390/kvm/interrupt.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
> index 2a711bae69a7..bd9b339bbb5e 100644
> --- a/arch/s390/kvm/interrupt.c
> +++ b/arch/s390/kvm/interrupt.c
> @@ -2312,7 +2312,7 @@ static int flic_ais_mode_get_all(struct kvm *kvm, struct kvm_device_attr *attr)
> return -EINVAL;
>
> if (!test_kvm_facility(kvm, 72))
> - return -ENOTSUPP;
> + return -EOPNOTSUPP;
>
> mutex_lock(&fi->ais_lock);
> ais.simm = fi->simm;
> @@ -2621,7 +2621,7 @@ static int modify_ais_mode(struct kvm *kvm, struct kvm_device_attr *attr)
> int ret = 0;
>
> if (!test_kvm_facility(kvm, 72))
> - return -ENOTSUPP;
> + return -EOPNOTSUPP;
>
> if (copy_from_user(&req, (void __user *)attr->addr, sizeof(req)))
> return -EFAULT;
> @@ -2701,7 +2701,7 @@ static int flic_ais_mode_set_all(struct kvm *kvm, struct kvm_device_attr *attr)
> struct kvm_s390_ais_all ais;
>
> if (!test_kvm_facility(kvm, 72))
> - return -ENOTSUPP;
> + return -EOPNOTSUPP;
>
> if (copy_from_user(&ais, (void __user *)attr->addr, sizeof(ais)))
> return -EFAULT;
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-12-05 17:08 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-05 12:51 [PATCH] KVM: s390: ENOTSUPP -> EOPNOTSUPP fixups Christian Borntraeger
2019-12-05 13:05 ` Cornelia Huck
2019-12-05 13:09 ` Thomas Huth
2019-12-05 13:16 ` Christian Borntraeger
2019-12-05 16:09 ` Heiko Carstens
2019-12-05 17:07 ` Christian Borntraeger
2019-12-05 14:50 ` Christian Borntraeger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox