From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06D18C43603 for ; Mon, 9 Dec 2019 16:54:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE35B2077B for ; Mon, 9 Dec 2019 16:54:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fplIkMzN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726230AbfLIQyn (ORCPT ); Mon, 9 Dec 2019 11:54:43 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:49972 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726342AbfLIQyn (ORCPT ); Mon, 9 Dec 2019 11:54:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575910481; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qyTDNt9dcVhgpPpYvZfl+wuXkSEUUPLFfNjqTrmJ1GA=; b=fplIkMzNN37kIa8wb3UGin9YVy3rSRlR7GBeaKSmDf5XSdSRAkKYfmLlJ885OLY3kqPFpB WCFWxu3y4rU4+Qn2ZjR3+YDsAgVbjd6p60wV2Bue5h55rtQdXF1Vk2rJ4eT5wzUQEqynCb IFTdbY4cLkUN0Z3dlmzcHBi2YY6siHM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-7-5SgfpZgQNXOVzLTBOVvASw-1; Mon, 09 Dec 2019 11:54:38 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1CCA48017DF; Mon, 9 Dec 2019 16:54:37 +0000 (UTC) Received: from gondolin (ovpn-116-43.ams2.redhat.com [10.36.116.43]) by smtp.corp.redhat.com (Postfix) with ESMTP id DEA565C21B; Mon, 9 Dec 2019 16:54:32 +0000 (UTC) Date: Mon, 9 Dec 2019 17:54:30 +0100 From: Cornelia Huck To: Pierre Morel Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, frankja@linux.ibm.com, david@redhat.com, thuth@redhat.com Subject: Re: [kvm-unit-tests PATCH v3 7/9] s390x: css: msch, enable test Message-ID: <20191209175430.5381b328.cohuck@redhat.com> In-Reply-To: <1575649588-6127-8-git-send-email-pmorel@linux.ibm.com> References: <1575649588-6127-1-git-send-email-pmorel@linux.ibm.com> <1575649588-6127-8-git-send-email-pmorel@linux.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: 5SgfpZgQNXOVzLTBOVvASw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, 6 Dec 2019 17:26:26 +0100 Pierre Morel wrote: > A second step when testing the channel subsystem is to prepare a channel > for use. > This includes: > - Get the current SubCHannel Information Block (SCHIB) using STSCH > - Update it in memory to set the ENABLE bit > - Tell the CSS that the SCHIB has been modified using MSCH > - Get the SCHIB from the CSS again to verify that the subchannel is > enabled. > > This tests the success of the MSCH instruction by enabling a channel. > > Signed-off-by: Pierre Morel > --- > s390x/css.c | 39 +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > > diff --git a/s390x/css.c b/s390x/css.c > index 3d4a986..4c0031c 100644 > --- a/s390x/css.c > +++ b/s390x/css.c > @@ -58,11 +58,50 @@ static void test_enumerate(void) > report("Tested %d devices, %d found", 1, scn, found); > } > > +static void test_enable(void) > +{ > + struct pmcw *pmcw = &schib.pmcw; > + int cc; > + > + if (!test_device_sid) { > + report_skip("No device"); > + return; > + } > + /* Read the SCIB for this subchannel */ s/SCIB/SCHIB/ > + cc = stsch(test_device_sid, &schib); > + if (cc) { > + report("stsch cc=%d", 0, cc); > + return; > + } > + /* Update the SCHIB to enable the channel */ > + pmcw->flags |= PMCW_ENABLE; > + > + /* Tell the CSS we want to modify the subchannel */ > + cc = msch(test_device_sid, &schib); > + if (cc) { > + report("msch cc=%d", 0, cc); So you expect the subchannel to be idle? Probably true, especially as QEMU has no reason to post an unsolicited interrupt for a test device. > + return; > + } > + > + /* Read the SCHIB again to verify the enablement */ > + cc = stsch(test_device_sid, &schib); > + if (cc) { > + report("stsch cc=%d", 0, cc); > + return; > + } > + if (!(pmcw->flags & PMCW_ENABLE)) { > + report("Enable failed. pmcw: %x", 0, pmcw->flags); This check is fine when running under KVM. If this test is modified to run under z/VM in the future, you probably should retry here: I've seen the enable bit 'stick' only after the second msch() there. > + return; > + } > + report("Tested", 1); > +} > + > static struct { > const char *name; > void (*func)(void); > } tests[] = { > { "enumerate (stsch)", test_enumerate }, > + { "enable (msch)", test_enable }, > { NULL, NULL } > }; >