From: Cornelia Huck <cohuck@redhat.com>
To: Pierre Morel <pmorel@linux.ibm.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
frankja@linux.ibm.com, david@redhat.com, thuth@redhat.com
Subject: Re: [kvm-unit-tests PATCH v4 8/9] s390x: css: ssch/tsch with sense and interrupt
Date: Fri, 13 Dec 2019 10:43:50 +0100 [thread overview]
Message-ID: <20191213104350.6ebe4aa6.cohuck@redhat.com> (raw)
In-Reply-To: <96034dbc-489a-7f76-0402-d5c0c42d20b3@linux.ibm.com>
On Thu, 12 Dec 2019 19:20:07 +0100
Pierre Morel <pmorel@linux.ibm.com> wrote:
> On 2019-12-12 15:10, Pierre Morel wrote:
> >
> >
> > On 2019-12-12 13:26, Cornelia Huck wrote:
> >> On Wed, 11 Dec 2019 16:46:09 +0100
> >> Pierre Morel <pmorel@linux.ibm.com> wrote:
> >>> +
> >>> + senseid.cu_type = buffer[2] | (buffer[1] << 8);
> >>
> >> This still looks odd; why not have the ccw fill out the senseid
> >> structure directly?
> >
> > Oh sorry, you already said and I forgot to modify this.
> > thanks
>
> hum, sorry, I forgot, the sense structure is not padded so I need this.
Very confused; I see padding in the senseid structure? (And what does
padding have to do with it?)
Also, you only copy the cu type... it would really be much better if
you looked at the whole structure you got back from the hypervisor;
that would also allow you to do some more sanity checks etc. If you
really can't pass in a senseid structure directly, just copy everything
you got?
next prev parent reply other threads:[~2019-12-13 9:44 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 15:46 [kvm-unit-tests PATCH v4 0/9] s390x: Testing the Channel Subsystem I/O Pierre Morel
2019-12-11 15:46 ` [kvm-unit-tests PATCH v4 1/9] s390x: saving regs for interrupts Pierre Morel
2019-12-12 9:24 ` Janosch Frank
2019-12-12 13:32 ` Pierre Morel
2019-12-11 15:46 ` [kvm-unit-tests PATCH v4 2/9] s390x: Use PSW bits definitions in cstart Pierre Morel
2019-12-12 9:31 ` Janosch Frank
2019-12-12 13:34 ` Pierre Morel
2019-12-11 15:46 ` [kvm-unit-tests PATCH v4 3/9] s390x: interrupt registration Pierre Morel
2019-12-12 9:39 ` Janosch Frank
2019-12-12 13:35 ` Pierre Morel
2019-12-12 9:41 ` Janosch Frank
2019-12-12 13:35 ` Pierre Morel
2019-12-11 15:46 ` [kvm-unit-tests PATCH v4 4/9] s390x: export the clock get_clock_ms() utility Pierre Morel
2019-12-12 9:40 ` Janosch Frank
2019-12-12 13:36 ` Pierre Morel
2019-12-11 15:46 ` [kvm-unit-tests PATCH v4 5/9] s390x: Library resources for CSS tests Pierre Morel
2019-12-12 9:51 ` Janosch Frank
2019-12-12 13:43 ` Pierre Morel
2019-12-11 15:46 ` [kvm-unit-tests PATCH v4 6/9] s390x: css: stsch, enumeration test Pierre Morel
2019-12-12 10:18 ` Cornelia Huck
2019-12-12 13:50 ` Pierre Morel
2019-12-11 15:46 ` [kvm-unit-tests PATCH v4 7/9] s390x: css: msch, enable test Pierre Morel
2019-12-12 12:01 ` Cornelia Huck
2019-12-12 14:01 ` Pierre Morel
2019-12-12 14:10 ` Cornelia Huck
2019-12-12 14:21 ` Pierre Morel
2019-12-12 14:33 ` Cornelia Huck
2019-12-12 16:05 ` Pierre Morel
2019-12-12 17:33 ` Pierre Morel
2019-12-13 9:33 ` Cornelia Huck
2019-12-13 14:40 ` Pierre Morel
2019-12-11 15:46 ` [kvm-unit-tests PATCH v4 8/9] s390x: css: ssch/tsch with sense and interrupt Pierre Morel
2019-12-12 12:26 ` Cornelia Huck
2019-12-12 14:10 ` Pierre Morel
2019-12-12 18:20 ` Pierre Morel
2019-12-13 9:43 ` Cornelia Huck [this message]
2019-12-13 15:24 ` Pierre Morel
2019-12-13 15:53 ` Cornelia Huck
2019-12-11 15:46 ` [kvm-unit-tests PATCH v4 9/9] s390x: css: ping pong Pierre Morel
2019-12-13 9:50 ` Cornelia Huck
2019-12-13 16:50 ` Pierre Morel
2019-12-16 10:54 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213104350.6ebe4aa6.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pmorel@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox