From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B47A4C43603 for ; Sun, 15 Dec 2019 09:51:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8358B2072B for ; Sun, 15 Dec 2019 09:51:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SpklDH62" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726260AbfLOJvx (ORCPT ); Sun, 15 Dec 2019 04:51:53 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:24066 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726231AbfLOJvx (ORCPT ); Sun, 15 Dec 2019 04:51:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576403511; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JexjbKDRWd+HP8U/4Z49W6xylkN1jU7Pq3Ic5X0J99U=; b=SpklDH62mqahdoACizxPwYwej8UDEmwvNgNsNB21sNELAYstPXvFn1lybbVIlSSD7G/0nt t6aKwDiviOo9jr630U9UyJ6g4zhUUia2nOPiwPZKlWs2+04t76qWyUquwReuJ7ebD9oeXz oqRo2dYqZBzvrqpoWoa9s3w53F4cBWA= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-343-LebLuhWQNw2AKvCLVyE1fg-1; Sun, 15 Dec 2019 04:51:50 -0500 X-MC-Unique: LebLuhWQNw2AKvCLVyE1fg-1 Received: by mail-qk1-f197.google.com with SMTP id n128so2606213qke.19 for ; Sun, 15 Dec 2019 01:51:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JexjbKDRWd+HP8U/4Z49W6xylkN1jU7Pq3Ic5X0J99U=; b=Qet0jkHC2ca2CA7f7drjdhQbVahSlCmPujdSVdlLIrRyss7ecoaF9YzS3nmkpzje0b Cm6l3H50/fiXE2wiqsROK+Gk2FVhgbIeNlzlFKSR1cK2GgkrIJJUCffP2cxw0GzRlf/s NWLiuYlUuhep4Ku1nyOuKe2if3occtzt6/DGVYEWarzif2w3ZacavxfwHneDylHq3Ze8 haf5bvTcCCM7Oom+dvC1t0z/srmPTyUZHnGgySdSh4RjX3LuuqmkjGNS1k/F1n7XL+cH DrmLnRBTpKms+HIlgykJfP2zCqUYWqUof1W1Xoxpv0tiM8+FPfPjtA1shqikKYAuTye8 +UtQ== X-Gm-Message-State: APjAAAW0kVnKbqDCfw3KNCN2tSej0kZma0PwUtzSo7EsYxGrr/xhxg59 rU4ET0Kam1/2LsouJutQ2J/IOSWopuIyPEaQ1+oU1JIoi5NciBIudxLT7dN8wss4A4eMz+rnGFb OM9jqG01MQ6o7 X-Received: by 2002:a0c:ea81:: with SMTP id d1mr21924157qvp.138.1576403509985; Sun, 15 Dec 2019 01:51:49 -0800 (PST) X-Google-Smtp-Source: APXvYqxfSUATHjxij/OAUPj2Tdys7QBapd5UqToJFM7KqoY6kKOmCY8gDA09+RZPd27hQyxK4UThdA== X-Received: by 2002:a0c:ea81:: with SMTP id d1mr21924140qvp.138.1576403509804; Sun, 15 Dec 2019 01:51:49 -0800 (PST) Received: from redhat.com (bzq-79-181-48-215.red.bezeqint.net. [79.181.48.215]) by smtp.gmail.com with ESMTPSA id h34sm5557924qtc.62.2019.12.15.01.51.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Dec 2019 01:51:49 -0800 (PST) Date: Sun, 15 Dec 2019 04:51:42 -0500 From: "Michael S. Tsirkin" To: Peter Maydell Cc: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , QEMU Developers , Andrew Baumann , Aurelien Jarno , kvm-devel , Alex Williamson , Aleksandar Markovic , Joel Stanley , qemu-arm , Marcelo Tosatti , Alistair Francis , Eduardo Habkost , Richard Henderson , Aleksandar Rikalo , Paul Burton , Marcel Apfelbaum , "Edgar E. Iglesias" , Paolo Bonzini Subject: Re: [PATCH 0/8] Simplify memory_region_add_subregion_overlap(..., priority=0) Message-ID: <20191215044759-mutt-send-email-mst@kernel.org> References: <20191214155614.19004-1-philmd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Sat, Dec 14, 2019 at 04:28:08PM +0000, Peter Maydell wrote: > (It doesn't actually assert that it doesn't > overlap because we have some legacy uses, notably > in the x86 PC machines, which do overlap without using > the right function, which we've never tried to tidy up.) It's not exactly legacy uses. To be more exact, the way the non overlap versions are *used* is to mean "I don't care what happens when they overlap" as opposed to "will never overlap". There are lots of regions where guest can make things overlapping but doesn't, e.g. PCI BARs can be programmed to overlap almost anything. What happens on real hardware if you then access one of the BARs is undefined, but programming itself is harmless. That's why we can't assert. -- MST