From: Alex Williamson <alex.williamson@redhat.com>
To: Liu Yi L <yi.l.liu@intel.com>
Cc: kwankhede@nvidia.com, kevin.tian@intel.com,
baolu.lu@linux.intel.com, yi.y.sun@intel.com, joro@8bytes.org,
jean-philippe.brucker@arm.com, peterx@redhat.com,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH v3 03/10] vfio_pci: refine vfio_pci_driver reference in vfio_pci.c
Date: Sun, 15 Dec 2019 15:46:42 -0700 [thread overview]
Message-ID: <20191215154642.1d4163bf@x1.home> (raw)
In-Reply-To: <1574335427-3763-4-git-send-email-yi.l.liu@intel.com>
On Thu, 21 Nov 2019 19:23:40 +0800
Liu Yi L <yi.l.liu@intel.com> wrote:
> This patch replaces the vfio_pci_driver reference in vfio_pci.c with
> pci_dev_driver(vdev->pdev) which is more helpful to make the functions
> be generic to module types.
>
> Cc: Kevin Tian <kevin.tian@intel.com>
> Cc: Lu Baolu <baolu.lu@linux.intel.com>
> Signed-off-by: Liu Yi L <yi.l.liu@intel.com>
> ---
> drivers/vfio/pci/vfio_pci.c | 33 ++++++++++++++++++---------------
> 1 file changed, 18 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c
> index b04e43a..2096e66 100644
> --- a/drivers/vfio/pci/vfio_pci.c
> +++ b/drivers/vfio/pci/vfio_pci.c
> @@ -1460,24 +1460,25 @@ static void vfio_pci_reflck_get(struct vfio_pci_reflck *reflck)
>
> static int vfio_pci_reflck_find(struct pci_dev *pdev, void *data)
> {
> - struct vfio_pci_reflck **preflck = data;
> + struct vfio_pci_device *vdev = data;
> + struct vfio_pci_reflck **preflck = &vdev->reflck;
> struct vfio_device *device;
> - struct vfio_pci_device *vdev;
> + struct vfio_pci_device *tmp;
>
> device = vfio_device_get_from_dev(&pdev->dev);
> if (!device)
> return 0;
>
> - if (pci_dev_driver(pdev) != &vfio_pci_driver) {
> + if (pci_dev_driver(pdev) != pci_dev_driver(vdev->pdev)) {
> vfio_device_put(device);
> return 0;
> }
>
> - vdev = vfio_device_data(device);
> + tmp = vfio_device_data(device);
>
> - if (vdev->reflck) {
> - vfio_pci_reflck_get(vdev->reflck);
> - *preflck = vdev->reflck;
> + if (tmp->reflck) {
> + vfio_pci_reflck_get(tmp->reflck);
> + *preflck = tmp->reflck;
> vfio_device_put(device);
> return 1;
> }
> @@ -1494,7 +1495,7 @@ static int vfio_pci_reflck_attach(struct vfio_pci_device *vdev)
>
> if (pci_is_root_bus(vdev->pdev->bus) ||
> vfio_pci_for_each_slot_or_bus(vdev->pdev, vfio_pci_reflck_find,
> - &vdev->reflck, slot) <= 0)
> + vdev, slot) <= 0)
> vdev->reflck = vfio_pci_reflck_alloc();
>
> mutex_unlock(&reflck_lock);
> @@ -1519,6 +1520,7 @@ static void vfio_pci_reflck_put(struct vfio_pci_reflck *reflck)
>
> struct vfio_devices {
> struct vfio_device **devices;
> + struct vfio_pci_device *vdev;
> int cur_index;
> int max_index;
> };
> @@ -1527,7 +1529,7 @@ static int vfio_pci_get_unused_devs(struct pci_dev *pdev, void *data)
> {
> struct vfio_devices *devs = data;
> struct vfio_device *device;
> - struct vfio_pci_device *vdev;
> + struct vfio_pci_device *tmp;
>
> if (devs->cur_index == devs->max_index)
> return -ENOSPC;
> @@ -1536,15 +1538,15 @@ static int vfio_pci_get_unused_devs(struct pci_dev *pdev, void *data)
> if (!device)
> return -EINVAL;
>
> - if (pci_dev_driver(pdev) != &vfio_pci_driver) {
> + if (pci_dev_driver(pdev) != pci_dev_driver(devs->vdev->pdev)) {
> vfio_device_put(device);
> return -EBUSY;
> }
>
> - vdev = vfio_device_data(device);
> + tmp = vfio_device_data(device);
>
> /* Fault if the device is not unused */
> - if (vdev->refcnt) {
> + if (tmp->refcnt) {
> vfio_device_put(device);
> return -EBUSY;
> }
> @@ -1590,6 +1592,7 @@ static void vfio_pci_try_bus_reset(struct vfio_pci_device *vdev)
> if (!devs.devices)
> return;
>
> + devs.vdev = vdev;
This could be added to the declaration initializer:
struct vfio_devices devs = { .vdev = vdev, .cur_index = 0 };
It might seem a little less random then. Thanks,
Alex
> if (vfio_pci_for_each_slot_or_bus(vdev->pdev,
> vfio_pci_get_unused_devs,
> &devs, slot))
> @@ -1634,7 +1637,7 @@ static void __exit vfio_pci_cleanup(void)
> vfio_pci_uninit_perm_bits();
> }
>
> -static void __init vfio_pci_fill_ids(char *ids)
> +static void __init vfio_pci_fill_ids(char *ids, struct pci_driver *driver)
> {
> char *p, *id;
> int rc;
> @@ -1662,7 +1665,7 @@ static void __init vfio_pci_fill_ids(char *ids)
> continue;
> }
>
> - rc = pci_add_dynid(&vfio_pci_driver, vendor, device,
> + rc = pci_add_dynid(driver, vendor, device,
> subvendor, subdevice, class, class_mask, 0);
> if (rc)
> pr_warn("failed to add dynamic id [%04x:%04x[%04x:%04x]] class %#08x/%08x (%d)\n",
> @@ -1689,7 +1692,7 @@ static int __init vfio_pci_init(void)
> if (ret)
> goto out_driver;
>
> - vfio_pci_fill_ids(ids);
> + vfio_pci_fill_ids(ids, &vfio_pci_driver);
>
> return 0;
>
next prev parent reply other threads:[~2019-12-15 22:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 11:23 [PATCH v3 00/10] vfio_pci: wrap pci device as a mediated device Liu Yi L
2019-11-21 11:23 ` [PATCH v3 01/10] vfio_pci: move vfio_pci_is_vga/vfio_vga_disabled to header Liu Yi L
2019-11-21 11:23 ` [PATCH v3 02/10] vfio_pci: refine user config reference in vfio-pci module Liu Yi L
2019-11-21 11:23 ` [PATCH v3 03/10] vfio_pci: refine vfio_pci_driver reference in vfio_pci.c Liu Yi L
2019-12-15 22:46 ` Alex Williamson [this message]
2019-12-16 11:59 ` Liu, Yi L
2019-11-21 11:23 ` [PATCH v3 04/10] vfio_pci: make common functions be extern Liu Yi L
2019-11-21 11:23 ` [PATCH v3 05/10] vfio_pci: duplicate vfio_pci.c Liu Yi L
2019-11-21 11:23 ` [PATCH v3 06/10] vfio_pci: shrink vfio_pci_common.c Liu Yi L
2019-11-21 11:23 ` [PATCH v3 07/10] vfio_pci: shrink vfio_pci.c Liu Yi L
2019-11-21 11:23 ` [PATCH v3 08/10] vfio/pci: protect cap/ecap_perm bits alloc/free Liu Yi L
2019-12-15 22:46 ` Alex Williamson
2019-12-16 11:57 ` Liu, Yi L
2019-12-16 17:42 ` Alex Williamson
2020-01-06 5:29 ` Liu, Yi L
2019-11-21 11:23 ` [PATCH v3 09/10] samples: add vfio-mdev-pci driver Liu Yi L
2019-11-21 11:23 ` [PATCH v3 10/10] samples: refine " Liu Yi L
2019-12-09 11:49 ` [PATCH v3 00/10] vfio_pci: wrap pci device as a mediated device Liu, Yi L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191215154642.1d4163bf@x1.home \
--to=alex.williamson@redhat.com \
--cc=baolu.lu@linux.intel.com \
--cc=jean-philippe.brucker@arm.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterx@redhat.com \
--cc=yi.l.liu@intel.com \
--cc=yi.y.sun@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox