Re: [PATCH v4 02/12] vfio_pci: move vfio_pci_is_vga/vfio_vga_disabled to header file

Cornelia Huck
2020-01-15T10:43:40Z

On Tue, 7 Jan 2020 20:01:39 +0800
Liu Yi L <yi.l.liu@intel.com> wrote:

> This patch moves two inline functions to vfio_pci_private.h for further
> sharing across source files. Also avoids below compiling error in further
> code split.
>
> "error: inlining failed in call to always_inline ‘vfio_pci_is_vga’:
> function body not available".

"We want to use these functions from other files, so move them to a
header" seems to be justification enough; why mention the compilation
error?

>
> Cc: Kevin Tian <kevin.tian@intel.com>
> Cc: Lu Baolu <baolu.lu@linux.intel.com>
> Signed-off-by: Liu Yi L <yi.l.liu@intel.com>
> ---
> drivers/vfio/pci/vfio_pci.c | 14 --------------
> drivers/vfio/pci/vfio_pci_private.h | 14 ++++++++++++++
> 2 files changed, 14 insertions(+), 14 deletions(-)