Re: [kvm-unit-tests PATCH v2 7/7] s390x: smp: Dirty fpc before initial reset test

David Hildenbrand
2020-01-17T10:20:43Z

On 16.01.20 13:05, Janosch Frank wrote:
> Let's dirty the fpc, before we test if the initial reset sets it to 0.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
> ---
> s390x/smp.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/s390x/smp.c b/s390x/smp.c
> index ce3215d..97a9dda 100644
> --- a/s390x/smp.c
> +++ b/s390x/smp.c
> @@ -179,6 +179,9 @@ static void test_emcall(void)
> /* Used to dirty registers of cpu #1 before it is reset */
> static void test_func_initial(void)
> {
> + asm volatile(
> + " sfpc %0\n"
> + : : "d" (0x11) : );

FWIW, I'd make this one easier to read

asm volatile("sfpc %0\n" :: "d" (0x11));

or sth like that

Reviewed-by: David Hildenbrand <david@redhat.com>

> lctlg(1, 0x42000UL);
> lctlg(7, 0x43000UL);
> lctlg(13, 0x44000UL);
>

--
Thanks,

David / dhildenb