From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5DD6C3F68F for ; Mon, 20 Jan 2020 03:56:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 72CD12073D for ; Mon, 20 Jan 2020 03:56:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ozlabs.org header.i=@ozlabs.org header.b="dUAKAq0v" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729095AbgATD4v (ORCPT ); Sun, 19 Jan 2020 22:56:51 -0500 Received: from ozlabs.org ([203.11.71.1]:56027 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729011AbgATD4v (ORCPT ); Sun, 19 Jan 2020 22:56:51 -0500 Received: by ozlabs.org (Postfix, from userid 1003) id 481Hsr4GqVz9sRK; Mon, 20 Jan 2020 14:56:48 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ozlabs.org; s=201707; t=1579492608; bh=lAGKBdtognRp9MuKBdR+5b2SjLz9x55FpMJWqSfQ6qY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dUAKAq0v+fVttWJxioZvNG0BtMhcZUat99t698VbzX1F/zlmSKB330Etdpr8dhc76 LgQ0zJdbhuyR1H/vR0aYkaoRDTWcKoSWaqcXj6ErDly+Tn2yz7PSXHSNyMImPMl9tP xyavDDW3J6vU7xLt0EzjiAP8W7GOt+xqqQHnwlIoIwKSt8mNIQuX2kFmVUUOR/AB+1 223kTr75BFvJJpA2PeWzgxHtia7sYccOJwK6fdQs+TGCFIgaTI9QqAo127pLrxO2BS vw/3QB56iD9jMWi9IFVNiAA2HJNbXbWM7qMcFTfg7AwfcraXsEohfC0CAqwPxUayYv d19QF6AMoz1qQ== Date: Mon, 20 Jan 2020 14:56:44 +1100 From: Paul Mackerras To: Sean Christopherson Cc: Marc Zyngier , James Hogan , Christian Borntraeger , Janosch Frank , Paolo Bonzini , James Morse , Julien Thierry , Suzuki K Poulose , David Hildenbrand , Cornelia Huck , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kurz Subject: Re: [PATCH v2 15/45] KVM: PPC: Move kvm_vcpu_init() invocation to common code Message-ID: <20200120035644.GE14307@blackberry> References: <20191218215530.2280-1-sean.j.christopherson@intel.com> <20191218215530.2280-16-sean.j.christopherson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191218215530.2280-16-sean.j.christopherson@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Dec 18, 2019 at 01:55:00PM -0800, Sean Christopherson wrote: > Move the kvm_cpu_{un}init() calls to common PPC code as an intermediate > step towards removing kvm_cpu_{un}init() altogether. > > No functional change intended. Another error to fix: > diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c > index 047c9f707704..dd7440e50c7a 100644 > --- a/arch/powerpc/kvm/booke.c > +++ b/arch/powerpc/kvm/booke.c > @@ -2114,10 +2114,9 @@ int kvmppc_core_init_vm(struct kvm *kvm) > return kvm->arch.kvm_ops->init_vm(kvm); > } > > -int kvmppc_core_vcpu_create(struct kvm *kvm, struct kvm_vcpu *vcpu, > - unsigned int id) > +int kvmppc_core_vcpu_create(struct kvm_vcpu *vcpu) > { > - return kvm->arch.kvm_ops->vcpu_create(kvm, vcpu, id); > + return kvm->arch.kvm_ops->vcpu_create(vcpu); This also needs s/kvm/vcpu->kvm/. Paul.