From: Wainer dos Santos Moschetta <wainersm@redhat.com>
To: kvm@vger.kernel.org
Cc: pbonzini@redhat.com, drjones@redhat.com
Subject: [kvm-unit-tests v2 1/2] README: Fix markdown formatting
Date: Mon, 20 Jan 2020 16:43:09 -0300 [thread overview]
Message-ID: <20200120194310.3942-2-wainersm@redhat.com> (raw)
In-Reply-To: <20200120194310.3942-1-wainersm@redhat.com>
There are formatting issues that prevent README.md
from being rendered correctly in a browser. This
patch fixes the following categories of issues:
- blocks which aren't indented correctly;
- texts wrapped in <> which need escape, or
be replaced with another thing.
Also some inline commands are marked with ``.
Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
---
README.md | 72 ++++++++++++++++++++++++++++++-------------------------
1 file changed, 39 insertions(+), 33 deletions(-)
diff --git a/README.md b/README.md
index 1a9a4ab..367c92a 100644
--- a/README.md
+++ b/README.md
@@ -13,12 +13,11 @@ To create the test images do:
./configure
make
-in this directory. Test images are created in ./<ARCH>/*.flat
+in this directory. Test images are created in ./ARCH/\*.flat
## Standalone tests
-The tests can be built as standalone
-To create and use standalone tests do:
+The tests can be built as standalone. To create and use standalone tests do:
./configure
make standalone
@@ -26,7 +25,7 @@ To create and use standalone tests do:
(go to somewhere)
./some-test
-'make install' will install all tests in PREFIX/share/kvm-unit-tests/tests,
+`make install` will install all tests in PREFIX/share/kvm-unit-tests/tests,
each as a standalone test.
@@ -42,39 +41,40 @@ or:
to run them all.
-To select a specific qemu binary, specify the QEMU=<path>
+By default the runner script searches for a suitable qemu binary in the system.
+To select a specific qemu binary though, specify the QEMU=path/to/binary
environment variable:
QEMU=/tmp/qemu/x86_64-softmmu/qemu-system-x86_64 ./x86-run ./x86/msr.flat
To select an accelerator, for example "kvm" or "tcg", specify the
-ACCEL=<name> environment variable:
+ACCEL=name environment variable:
ACCEL=kvm ./x86-run ./x86/msr.flat
# Unit test inputs
-Unit tests use QEMU's '-append <args...>' parameter for command line
+Unit tests use QEMU's '-append args...' parameter for command line
inputs, i.e. all args will be available as argv strings in main().
Additionally a file of the form
-KEY=VAL
-KEY2=VAL
-...
+ KEY=VAL
+ KEY2=VAL
+ ...
-may be passed with '-initrd <file>' to become the unit test's environ,
-which can then be accessed in the usual ways, e.g. VAL = getenv("KEY")
-Any key=val strings can be passed, but some have reserved meanings in
+may be passed with '-initrd file' to become the unit test's environ,
+which can then be accessed in the usual ways, e.g. VAL = getenv("KEY").
+ Any key=val strings can be passed, but some have reserved meanings in
the framework. The list of reserved environment variables is below
- QEMU_ACCEL ... either kvm or tcg
- QEMU_VERSION_STRING ... string of the form `qemu -h | head -1`
- KERNEL_VERSION_STRING ... string of the form `uname -r`
+ QEMU_ACCEL either kvm or tcg
+ QEMU_VERSION_STRING string of the form `qemu -h | head -1`
+ KERNEL_VERSION_STRING string of the form `uname -r`
Additionally these self-explanatory variables are reserved
- QEMU_MAJOR, QEMU_MINOR, QEMU_MICRO, KERNEL_VERSION, KERNEL_PATCHLEVEL,
- KERNEL_SUBLEVEL, KERNEL_EXTRAVERSION
+ QEMU_MAJOR, QEMU_MINOR, QEMU_MICRO, KERNEL_VERSION, KERNEL_PATCHLEVEL,
+ KERNEL_SUBLEVEL, KERNEL_EXTRAVERSION
# Guarding unsafe tests
@@ -85,42 +85,48 @@ host. kvm-unit-tests provides two ways to handle tests like those.
unittests.cfg file. When a unit test is in the nodefault group
it is only run when invoked
- a) independently, arch-run arch/test
- b) by specifying any other non-nodefault group it is in,
- groups = nodefault,mygroup : ./run_tests.sh -g mygroup
- c) by specifying all tests should be run, ./run_tests.sh -a
+ a) independently, `ARCH-run ARCH/test`
+
+ b) by specifying any other non-nodefault group it is in,
+ groups = nodefault,mygroup : `./run_tests.sh -g mygroup`
+
+ c) by specifying all tests should be run, `./run_tests.sh -a`
2) Making the test conditional on errata in the code,
+ ```
if (ERRATA(abcdef012345)) {
do_unsafe_test();
}
+ ```
With the errata condition the unsafe unit test is only run
when
- a) the ERRATA_abcdef012345 environ variable is provided and 'y'
- b) the ERRATA_FORCE environ variable is provided and 'y'
- c) by specifying all tests should be run, ./run_tests.sh -a
+ a) the ERRATA_abcdef012345 environment variable is provided and 'y'
+
+ b) the ERRATA_FORCE environment variable is provided and 'y'
+
+ c) by specifying all tests should be run, `./run_tests.sh -a`
(The -a switch ensures the ERRATA_FORCE is provided and set
to 'y'.)
-The errata.txt file provides a mapping of the commits needed by errata
+The ./errata.txt file provides a mapping of the commits needed by errata
conditionals to their respective minimum kernel versions. By default,
when the user does not provide an environ, then an environ generated
-from the errata.txt file and the host's kernel version is provided to
+from the ./errata.txt file and the host's kernel version is provided to
all unit tests.
# Contributing
## Directory structure
- .: configure script, top-level Makefile, and run_tests.sh
- ./scripts: helper scripts for building and running tests
- ./lib: general architecture neutral services for the tests
- ./lib/<ARCH>: architecture dependent services for the tests
- ./<ARCH>: the sources of the tests and the created objects/images
+ .: configure script, top-level Makefile, and run_tests.sh
+ ./scripts: helper scripts for building and running tests
+ ./lib: general architecture neutral services for the tests
+ ./lib/<ARCH>: architecture dependent services for the tests
+ ./<ARCH>: the sources of the tests and the created objects/images
-See <ARCH>/README for architecture specific documentation.
+See ./ARCH/README for architecture specific documentation.
## Style
--
2.23.0
next prev parent reply other threads:[~2020-01-20 19:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 19:43 [kvm-unit-tests v2 0/2] README: Markdown fixes and improvements Wainer dos Santos Moschetta
2020-01-20 19:43 ` Wainer dos Santos Moschetta [this message]
2020-01-21 9:18 ` [kvm-unit-tests v2 1/2] README: Fix markdown formatting Andrew Jones
2020-01-21 12:20 ` Paolo Bonzini
2020-01-20 19:43 ` [kvm-unit-tests v2 2/2] README: Add intro about the configuration file Wainer dos Santos Moschetta
2020-01-21 9:22 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120194310.3942-2-wainersm@redhat.com \
--to=wainersm@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox