From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86EA6C2D0CE for ; Tue, 21 Jan 2020 14:16:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 57DB022314 for ; Tue, 21 Jan 2020 14:16:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GMeUgo3x" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729211AbgAUOQP (ORCPT ); Tue, 21 Jan 2020 09:16:15 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:54388 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728794AbgAUOQP (ORCPT ); Tue, 21 Jan 2020 09:16:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579616173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OtPQLFnT52uoZGzAoyi/3S949ctnhGBbphedOmgQ5wE=; b=GMeUgo3xwSSqZFQVVCqem8PJakgboLjfmxp/buNGEGqtVTg6oKkI8UwL91xh8ICJ9Nwsr3 s5xr6kh3onHZeuPrC4de1YrVBoa+2GMTgShecEjSLL/SJtHKSPZNM9urWi+S6bhSYboeY9 SPn9pufD3m04dR9Ea1iztAD5llImJ0M= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-345-wiUETwfINwq_Ur61A2p_Bg-1; Tue, 21 Jan 2020 09:16:12 -0500 X-MC-Unique: wiUETwfINwq_Ur61A2p_Bg-1 Received: by mail-qv1-f69.google.com with SMTP id c1so1637553qvw.17 for ; Tue, 21 Jan 2020 06:16:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=OtPQLFnT52uoZGzAoyi/3S949ctnhGBbphedOmgQ5wE=; b=QCICa958aGuNZM0FCPA+OZi7W4Ky1br9AxTbxO/EQHNRZ/97jsWoQlIqJb3go2W0bU b2ssP6wQqGQdAVDOYL2qUizkhL2OrDBILZ2sfjeizPp0GquLFW+YoVuuwKClA/iVzAf1 SoJEXBwc91qbWcVsvNdiZjWx+3peRqrLDirHO/sFnEvbSAlpl9qXPJV9rJJROCupWjjA 1nr3FEKgEsGZa8iloW91yliAi2j9TDX3ycAXtYler5XCRdjp5Dz7HT4amjhVFlGe2yNE RVXHSFwNwUL4TP2UBrAascHK2ohjD0hdOl2FQr+1BqZ/s70KTy8Mqcd5cb4zqlSpSOjC VWsQ== X-Gm-Message-State: APjAAAUFDOjzX+i64KYOoZg6kVBtUb4GxV3nFSokaz7wx63XQXpEePUH n2FiK4e+EsFMaHzEs6vMwoZCIG+mIi9F1DkNLyiw1MWYIWtj9EzZnu+UwekB8I1sCcPqXoT3rhy tGQXTsSMcMe7v X-Received: by 2002:a37:4f8d:: with SMTP id d135mr4735784qkb.455.1579616172184; Tue, 21 Jan 2020 06:16:12 -0800 (PST) X-Google-Smtp-Source: APXvYqyQgYijZdgXt853mYL5TwvzVQ8pujRfHDSMvSEtlc0v2iUY5t9/9HUHWxN10Q3Sbj5SYLpKCg== X-Received: by 2002:a37:4f8d:: with SMTP id d135mr4735725qkb.455.1579616171759; Tue, 21 Jan 2020 06:16:11 -0800 (PST) Received: from redhat.com (bzq-79-179-85-180.red.bezeqint.net. [79.179.85.180]) by smtp.gmail.com with ESMTPSA id u55sm19847250qtc.28.2020.01.21.06.16.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2020 06:16:11 -0800 (PST) Date: Tue, 21 Jan 2020 09:16:02 -0500 From: "Michael S. Tsirkin" To: Jason Gunthorpe Cc: Shahaf Shuler , Jason Wang , Rob Miller , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , Netdev , "Bie, Tiwei" , "maxime.coquelin@redhat.com" , "Liang, Cunming" , "Wang, Zhihong" , "Wang, Xiao W" , "haotian.wang@sifive.com" , "Zhu, Lingshan" , "eperezma@redhat.com" , "lulu@redhat.com" , Parav Pandit , "Tian, Kevin" , "stefanha@redhat.com" , "rdunlap@infradead.org" , "hch@infradead.org" , Ariel Adam , "jakub.kicinski@netronome.com" , Jiri Pirko , "hanand@xilinx.com" , "mhabets@solarflare.com" Subject: Re: [PATCH 3/5] vDPA: introduce vDPA bus Message-ID: <20200121091540-mutt-send-email-mst@kernel.org> References: <20200116124231.20253-4-jasowang@redhat.com> <20200117070324-mutt-send-email-mst@kernel.org> <239b042c-2d9e-0eec-a1ef-b03b7e2c5419@redhat.com> <20200120174933.GB3891@mellanox.com> <20200120162449-mutt-send-email-mst@kernel.org> <20200121140755.GB12330@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200121140755.GB12330@mellanox.com> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Jan 21, 2020 at 02:07:59PM +0000, Jason Gunthorpe wrote: > On Mon, Jan 20, 2020 at 04:25:23PM -0500, Michael S. Tsirkin wrote: > > On Mon, Jan 20, 2020 at 08:51:43PM +0000, Shahaf Shuler wrote: > > > Monday, January 20, 2020 7:50 PM, Jason Gunthorpe: > > > > Subject: Re: [PATCH 3/5] vDPA: introduce vDPA bus > > > > > > > > On Mon, Jan 20, 2020 at 04:43:53PM +0800, Jason Wang wrote: > > > > > This is similar to the design of platform IOMMU part of vhost-vdpa. We > > > > > decide to send diffs to platform IOMMU there. If it's ok to do that in > > > > > driver, we can replace set_map with incremental API like map()/unmap(). > > > > > > > > > > Then driver need to maintain rbtree itself. > > > > > > > > I think we really need to see two modes, one where there is a fixed > > > > translation without dynamic vIOMMU driven changes and one that supports > > > > vIOMMU. > > > > > > > > There are different optimization goals in the drivers for these two > > > > configurations. > > > > > > +1. > > > It will be best to have one API for static config (i.e. mapping can be > > > set only before virtio device gets active), and one API for dynamic > > > changes that can be set after the virtio device is active. > > > > Frankly I don't see when we'd use the static one. > > Memory hotplug is enabled for most guests... > > If someone wants to run a full performance application, like dpdk, > then they may wish to trade memory hotplug in that VM for more > performance. Right. But let let's get basic functionality working first. > Perhaps Shahaf can quantify the performance delta? > > Jason