From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DFDAC2D0DB for ; Fri, 24 Jan 2020 15:28:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 20CD12077C for ; Fri, 24 Jan 2020 15:28:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ALrX7fm3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388021AbgAXP2z (ORCPT ); Fri, 24 Jan 2020 10:28:55 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:30293 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387599AbgAXP2z (ORCPT ); Fri, 24 Jan 2020 10:28:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579879733; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DUee2cmHHa3oQwc77ZPwfTujBJ+aW/aDK8eDAg7rA3c=; b=ALrX7fm3kj3YdEz4VMtsuT1ncPhck4pUj0xIK+a98tQhi2SkgHodGu3abnMU/P6Vc6XmGG DVhyDakcq638QoaltSwzYgDjHQWIChKFvPD7PRaFCTTg/1qVL1Sotbx5NtPaozSE2x9Lw7 r7WUBKuk//ug/CwdkSCU3QTMQQUYyDM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-266-lLkwEsseOOCbhJUd_CWMhA-1; Fri, 24 Jan 2020 10:28:48 -0500 X-MC-Unique: lLkwEsseOOCbhJUd_CWMhA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A73308F131; Fri, 24 Jan 2020 15:28:07 +0000 (UTC) Received: from gondolin (dhcp-192-195.str.redhat.com [10.33.192.195]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9B65D289B8; Fri, 24 Jan 2020 15:28:06 +0000 (UTC) Date: Fri, 24 Jan 2020 16:28:04 +0100 From: Cornelia Huck To: Eric Farman Cc: Halil Pasic , "Jason J . Herne" , Jared Rossi , linux-s390@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v1 0/1] vfio-ccw: Fix interrupt handling for HALT/CLEAR Message-ID: <20200124162804.1a32e22a.cohuck@redhat.com> In-Reply-To: <20200124145455.51181-1-farman@linux.ibm.com> References: <20200124145455.51181-1-farman@linux.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, 24 Jan 2020 15:54:54 +0100 Eric Farman wrote: > Conny, > > As I mentioned offline, I have been encountering some problems while > testing the channel path code. By pure coincidence, I found some > really good clues that led me to this proposed fix. I moved this > commit to the head of my channel path v2 code, but think maybe it > should be sent by itself so it doesn't get lost in that noise. > > Figure 16-6 in SA22-7832-12 (POPS) goes into great detail of the > contents of the irb.cpa based on the other bits in the IRB. > Both the existing code and this new patch treates the irb.cpa as > valid all the time, even though that table has many many entries > where the cpa contents are "unpredictable." Methinks that this > is partially how we got into this mess, so maybe I need to write > some smarter logic here anyway? Thoughts? Yes, we probably should go over this table a bit. I think the generic common I/O layer code has some checks where it does exactly that, but these are probably only done on the ccw_device level (i.e. in the normal I/O subchannel driver). Maybe we can refactor/reuse some of those checks? > > (Disclaimer1: I didn't go back and re-read the conversations > that were had for the commit I marked in the "Fixes:" tag, > but will just to make sure we didn't miss something.) > > (Disclaimer2: This makes my torturing-of-the-chpids test run > quite nicely, but I didn't go back to try some of the other > cruel-and-unusual tests at my disposable to ensure this patch > doesn't cause any other regressions. That's on today's agenda.) > > Eric Farman (1): > vfio-ccw: Don't free channel programs for unrelated interrupts > > drivers/s390/cio/vfio_ccw_cp.c | 11 +++++++++-- > drivers/s390/cio/vfio_ccw_cp.h | 2 +- > drivers/s390/cio/vfio_ccw_drv.c | 4 ++-- > 3 files changed, 12 insertions(+), 5 deletions(-) >