Re: [PATCH v9 2/6] KVM: s390: Cleanup initial cpu reset

Thomas Huth
2020-01-30T13:20:49Z

On 30/01/2020 13.34, Janosch Frank wrote:
> The code seems to be quite old and uses lots of unneeded spaces for
> alignment, which doesn't really help with readability.
>
> Let's:
> * Get rid of the extra spaces
> * Remove the ULs as they are not needed on 0s
> * Define constants for the CR 0 and 14 initial values
> * Use the sizeof of the gcr array to memset it to 0
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> Reviewed-by: David Hildenbrand <david@redhat.com>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
> ---
> arch/s390/include/asm/kvm_host.h | 5 +++++
> arch/s390/kvm/kvm-s390.c | 18 +++++++-----------
> 2 files changed, 12 insertions(+), 11 deletions(-)

Reviewed-by: Thomas Huth <thuth@redhat.com>