From: David Hildenbrand <david@redhat.com>
To: kvm@vger.kernel.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Thomas Huth <thuth@redhat.com>,
david@redhat.com, Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>
Subject: [kvm-unit-tests PULL 3/6] s390x: lib: fix stfl wrapper asm
Date: Thu, 30 Jan 2020 14:11:13 +0100 [thread overview]
Message-ID: <20200130131116.12386-4-david@redhat.com> (raw)
In-Reply-To: <20200130131116.12386-1-david@redhat.com>
From: Claudio Imbrenda <imbrenda@linux.ibm.com>
the stfl wrapper in lib/s390x/asm/facility.h was lacking the "memory"
clobber in the inline asm.
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Message-Id: <20200120184256.188698-4-imbrenda@linux.ibm.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
lib/s390x/asm/facility.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/s390x/asm/facility.h b/lib/s390x/asm/facility.h
index 5103dd4..e34dc2c 100644
--- a/lib/s390x/asm/facility.h
+++ b/lib/s390x/asm/facility.h
@@ -24,7 +24,7 @@ static inline bool test_facility(int nr)
static inline void stfl(void)
{
- asm volatile(" stfl 0(0)\n");
+ asm volatile(" stfl 0(0)\n" : : : "memory");
}
static inline void stfle(uint8_t *fac, unsigned int len)
--
2.24.1
next prev parent reply other threads:[~2020-01-30 13:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 13:11 [kvm-unit-tests PULL 0/6] s390x updates David Hildenbrand
2020-01-30 13:11 ` [kvm-unit-tests PULL 1/6] s390x: export sclp_setup_int David Hildenbrand
2020-01-30 13:11 ` [kvm-unit-tests PULL 2/6] s390x: sclp: add service call instruction wrapper David Hildenbrand
2020-01-30 13:11 ` David Hildenbrand [this message]
2020-01-30 13:11 ` [kvm-unit-tests PULL 4/6] s390x: lib: add SPX and STPX " David Hildenbrand
2020-01-30 13:11 ` [kvm-unit-tests PULL 5/6] s390x: lib: fix program interrupt handler if sclp_busy was set David Hildenbrand
2020-01-30 13:11 ` [kvm-unit-tests PULL 6/6] s390x: SCLP unit test David Hildenbrand
2020-01-30 17:12 ` [kvm-unit-tests PULL 0/6] s390x updates Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200130131116.12386-4-david@redhat.com \
--to=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox