From: Thomas Huth <thuth@redhat.com>
To: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
Cc: david@redhat.com, Wainer dos Santos Moschetta <wainersm@redhat.com>
Subject: [kvm-unit-tests PULL 9/9] travis.yml: Prevent 'script' from premature exit
Date: Tue, 4 Feb 2020 08:13:35 +0100 [thread overview]
Message-ID: <20200204071335.18180-10-thuth@redhat.com> (raw)
In-Reply-To: <20200204071335.18180-1-thuth@redhat.com>
From: Wainer dos Santos Moschetta <wainersm@redhat.com>
The 'script' section finishes its execution prematurely whenever
a shell's exit is called. If the intention is to force
Travis to flag a build/test failure then the correct approach
is erroring any command statement. In this change, it combines
the grep's in a single AND statement that in case of false
Travis will interpret as a build error.
Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Message-Id: <20200115144610.41655-1-wainersm@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
.travis.yml | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 091d071..f0cfc82 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -119,5 +119,4 @@ before_script:
script:
- make -j3
- ACCEL="${ACCEL:-tcg}" ./run_tests.sh -v $TESTS | tee results.txt
- - if grep -q FAIL results.txt ; then exit 1 ; fi
- - if ! grep -q PASS results.txt ; then exit 1 ; fi
+ - grep -q PASS results.txt && ! grep -q FAIL results.txt
--
2.18.1
next prev parent reply other threads:[~2020-02-04 7:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 7:13 [kvm-unit-tests PULL 0/9] s390x and CI patches Thomas Huth
2020-02-04 7:13 ` [kvm-unit-tests PULL 1/9] s390x: smp: Cleanup smp.c Thomas Huth
2020-02-04 7:13 ` [kvm-unit-tests PULL 2/9] s390x: smp: Fix ecall and emcall report strings Thomas Huth
2020-02-04 7:13 ` [kvm-unit-tests PULL 3/9] s390x: Stop the cpu that is executing exit() Thomas Huth
2020-02-04 7:13 ` [kvm-unit-tests PULL 4/9] s390x: Add cpu id to interrupt error prints Thomas Huth
2020-02-04 7:13 ` [kvm-unit-tests PULL 5/9] s390x: smp: Only use smp_cpu_setup once Thomas Huth
2020-02-04 7:13 ` [kvm-unit-tests PULL 6/9] s390x: smp: Rework cpu start and active tracking Thomas Huth
2020-02-04 7:13 ` [kvm-unit-tests PULL 7/9] s390x: smp: Wait for cpu setup to finish Thomas Huth
2020-02-04 7:13 ` [kvm-unit-tests PULL 8/9] gitlab-ci.yml: Remove ioapic from the x86 tests Thomas Huth
2020-02-04 7:13 ` Thomas Huth [this message]
2020-02-05 14:58 ` [kvm-unit-tests PULL 0/9] s390x and CI patches Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200204071335.18180-10-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=david@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox