public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
Cc: david@redhat.com, Janosch Frank <frankja@linux.ibm.com>
Subject: [kvm-unit-tests PULL 7/9] s390x: smp: Wait for cpu setup to finish
Date: Tue,  4 Feb 2020 08:13:33 +0100	[thread overview]
Message-ID: <20200204071335.18180-8-thuth@redhat.com> (raw)
In-Reply-To: <20200204071335.18180-1-thuth@redhat.com>

From: Janosch Frank <frankja@linux.ibm.com>

We store the user provided psw address into restart new, so a psw
restart does not lead us through setup again.

Also we wait on smp_cpu_setup() until the cpu has finished setup
before returning. This is necessary for z/VM and LPAR where sigp is
asynchronous.

Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Message-Id: <20200201152851.82867-8-frankja@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 lib/s390x/smp.c  | 3 +++
 s390x/cstart64.S | 2 ++
 2 files changed, 5 insertions(+)

diff --git a/lib/s390x/smp.c b/lib/s390x/smp.c
index 4578003..3f86243 100644
--- a/lib/s390x/smp.c
+++ b/lib/s390x/smp.c
@@ -210,6 +210,9 @@ int smp_cpu_setup(uint16_t addr, struct psw psw)
 
 	/* Start processing */
 	smp_cpu_restart_nolock(addr, NULL);
+	/* Wait until the cpu has finished setup and started the provided psw */
+	while (lc->restart_new_psw.addr != psw.addr)
+		mb();
 out:
 	spin_unlock(&lock);
 	return rc;
diff --git a/s390x/cstart64.S b/s390x/cstart64.S
index 86dd4c4..9af6bb3 100644
--- a/s390x/cstart64.S
+++ b/s390x/cstart64.S
@@ -159,6 +159,8 @@ smp_cpu_setup_state:
 	xgr	%r1, %r1
 	lmg     %r0, %r15, GEN_LC_SW_INT_GRS
 	lctlg   %c0, %c0, GEN_LC_SW_INT_CRS
+	/* We should only go once through cpu setup and not for every restart */
+	stg	%r14, GEN_LC_RESTART_NEW_PSW + 8
 	br	%r14
 
 pgm_int:
-- 
2.18.1


  parent reply	other threads:[~2020-02-04  7:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-04  7:13 [kvm-unit-tests PULL 0/9] s390x and CI patches Thomas Huth
2020-02-04  7:13 ` [kvm-unit-tests PULL 1/9] s390x: smp: Cleanup smp.c Thomas Huth
2020-02-04  7:13 ` [kvm-unit-tests PULL 2/9] s390x: smp: Fix ecall and emcall report strings Thomas Huth
2020-02-04  7:13 ` [kvm-unit-tests PULL 3/9] s390x: Stop the cpu that is executing exit() Thomas Huth
2020-02-04  7:13 ` [kvm-unit-tests PULL 4/9] s390x: Add cpu id to interrupt error prints Thomas Huth
2020-02-04  7:13 ` [kvm-unit-tests PULL 5/9] s390x: smp: Only use smp_cpu_setup once Thomas Huth
2020-02-04  7:13 ` [kvm-unit-tests PULL 6/9] s390x: smp: Rework cpu start and active tracking Thomas Huth
2020-02-04  7:13 ` Thomas Huth [this message]
2020-02-04  7:13 ` [kvm-unit-tests PULL 8/9] gitlab-ci.yml: Remove ioapic from the x86 tests Thomas Huth
2020-02-04  7:13 ` [kvm-unit-tests PULL 9/9] travis.yml: Prevent 'script' from premature exit Thomas Huth
2020-02-05 14:58 ` [kvm-unit-tests PULL 0/9] s390x and CI patches Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200204071335.18180-8-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=david@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox