From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF104C352A3 for ; Mon, 10 Feb 2020 12:31:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF7772085B for ; Mon, 10 Feb 2020 12:31:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iw8AhcHk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727363AbgBJMbe (ORCPT ); Mon, 10 Feb 2020 07:31:34 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:48513 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726950AbgBJMbe (ORCPT ); Mon, 10 Feb 2020 07:31:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581337893; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z1Vu1maQTpBDvCRALrAvpDS5q5kK3fJYx8cOOVPbIT0=; b=iw8AhcHkWjaRZRqPITj5Su+3ebLGEfT5v2kBontwAxY5f8eNver640vGPLEBakpzrTju0b HYywFMzy8oXxrX37phKsC1JdBSEUnYrTd8B6LkdSiRdydSyg/PxvN+399ffxG/cRKV+3uu gN7iTQJPrL+//Yp8Vipq541Oo/qWcEI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-275-RDZeIp7TO6-PEAwLNX4XAQ-1; Mon, 10 Feb 2020 07:31:31 -0500 X-MC-Unique: RDZeIp7TO6-PEAwLNX4XAQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E9D8DA0CC0; Mon, 10 Feb 2020 12:31:29 +0000 (UTC) Received: from gondolin (ovpn-117-244.ams2.redhat.com [10.36.117.244]) by smtp.corp.redhat.com (Postfix) with ESMTP id 463EF10013A7; Mon, 10 Feb 2020 12:31:25 +0000 (UTC) Date: Mon, 10 Feb 2020 13:31:22 +0100 From: Cornelia Huck To: Christian Borntraeger Cc: Janosch Frank , KVM , David Hildenbrand , Thomas Huth , Ulrich Weigand , Claudio Imbrenda , Andrea Arcangeli , linux-s390 , Michael Mueller , Vasily Gorbik Subject: Re: [PATCH 03/35] s390/protvirt: introduce host side setup Message-ID: <20200210133122.2a5a799c.cohuck@redhat.com> In-Reply-To: References: <20200207113958.7320-1-borntraeger@de.ibm.com> <20200207113958.7320-4-borntraeger@de.ibm.com> <20200210125452.7f66706d.cohuck@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, 10 Feb 2020 13:14:03 +0100 Christian Borntraeger wrote: > On 10.02.20 12:54, Cornelia Huck wrote: > > On Fri, 7 Feb 2020 06:39:26 -0500 > > Christian Borntraeger wrote: > > > >> From: Vasily Gorbik > >> > >> Add "prot_virt" command line option which controls if the kernel > >> protected VMs support is enabled at early boot time. This has to be > >> done early, because it needs large amounts of memory and will disable > >> some features like STP time sync for the lpar. > >> > >> Extend ultravisor info definitions and expose it via uv_info struct > >> filled in during startup. > >> > >> Signed-off-by: Vasily Gorbik > >> [borntraeger@de.ibm.com: patch merging, splitting, fixing] > >> Signed-off-by: Christian Borntraeger > >> --- > >> .../admin-guide/kernel-parameters.txt | 5 ++ > >> arch/s390/boot/Makefile | 2 +- > >> arch/s390/boot/uv.c | 21 +++++++- > >> arch/s390/include/asm/uv.h | 46 +++++++++++++++-- > >> arch/s390/kernel/Makefile | 1 + > >> arch/s390/kernel/setup.c | 4 -- > >> arch/s390/kernel/uv.c | 49 +++++++++++++++++++ > >> 7 files changed, 119 insertions(+), 9 deletions(-) > >> create mode 100644 arch/s390/kernel/uv.c > > > > (...) > > > >> diff --git a/arch/s390/boot/Makefile b/arch/s390/boot/Makefile > >> index e2c47d3a1c89..30f1811540c5 100644 > >> --- a/arch/s390/boot/Makefile > >> +++ b/arch/s390/boot/Makefile > >> @@ -37,7 +37,7 @@ CFLAGS_sclp_early_core.o += -I$(srctree)/drivers/s390/char > >> obj-y := head.o als.o startup.o mem_detect.o ipl_parm.o ipl_report.o > >> obj-y += string.o ebcdic.o sclp_early_core.o mem.o ipl_vmparm.o cmdline.o > >> obj-y += version.o pgm_check_info.o ctype.o text_dma.o > >> -obj-$(CONFIG_PROTECTED_VIRTUALIZATION_GUEST) += uv.o > >> +obj-$(findstring y, $(CONFIG_PROTECTED_VIRTUALIZATION_GUEST) $(CONFIG_PGSTE)) += uv.o > > > > I'm wondering why you're checking CONFIG_PGSTE here... > > It was just simpler for a Makefile, because CONFIG_KVM can be m or y. > PGSTE is always y when CONFIG_KVM is set. Suggestions welcome. My only complaint is that it is a bit non-obvious at a glance... but yeah, I don't have a better suggestion, either. > > [...] > > >> + prot_virt_host = 0; > >> + pr_info("Running as protected virtualization guest."); > >> + } > >> + > >> + if (prot_virt_host && !test_facility(158)) { > >> + prot_virt_host = 0; > >> + pr_info("The ultravisor call facility is not available."); > >> + } > > > > What about prefixing these two with 'prot_virt:'? It seems the name is > > settled now? > > It is not settled, but I can certainly do something like > > #define KMSG_COMPONENT "prot_virt" > #define pr_fmt(fmt) KMSG_COMPONENT ": " fmt > > > to prefix all pr_* calls in this file. That would make it easier to associate any messages (especially the second message here) with this feature, I think.