Re: [PATCH v2 50/66] KVM: x86: Override host CPUID results with kvm_cpu_caps

Sean Christopherson
2020-03-03T15:56:56Z

On Tue, Mar 03, 2020 at 04:22:48PM +0100, Paolo Bonzini wrote:
> On 03/03/20 00:56, Sean Christopherson wrote:
> > Override CPUID entries with kvm_cpu_caps during KVM_GET_SUPPORTED_CPUID
> > instead of masking the host CPUID result, which is redundant now that
> > the host CPUID is incorporated into kvm_cpu_caps at runtime.
> >
> > No functional change intended.
> >
> > Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> > Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
>
> The UMIP adjustment is now redundant in vmx_set_supported_cpuid, it's
> done in the next patch but it makes more sense to remove it here (so the
> next patch only moves code from set_supported_cpuid to set_cpu_caps).

Works for me.