Re: [PATCH v2 36/66] KVM: x86: Handle GBPAGE CPUID adjustment for EPT in VMX code

Paolo Bonzini
2020-03-03T15:47:54Z

On 03/03/20 16:44, Sean Christopherson wrote:
>>> Oof, that took me a long time to process. You're saying that KVM can
>>> allow the guest to use GBPAGES when shadow paging is enabled because KVM
>>> can effectively emulate GBPAGES. And IIUC, you're also saying that
>>> cpuid.GBPAGES should never be influenced by EPT restrictions.
>>>
>>> That all makes sense.
>> Yes, exactly.
> I'll tack that on to the front of the series. Should it be tagged Fixes?
> Feels like a fix, but is also more than a bit scary.

If you don't mind, I prefer to do the changes myself and also fix the
conflicts, in order to get my feet wet in the new cpu_caps world. I'll
push it to a temporary branch for you to take a look, possibly tomorrow.

Paolo