Re: [PATCH v2 1/4] x86/kvm/hyper-v: Align the hcall param for kvm_hyperv_exit

Paolo Bonzini
2020-03-05T15:29:59Z

On 05/03/20 15:53, Jon Doron wrote:
> Vitaly recommended we will align the struct to 64bit...

Oh, then I think you actually should add a padding after "__u32 type;"
and "__u32 msr;" if you want to make it explicit. The patch, as is, is
not aligning anything, hence my confusion.

Thanks,

Paolo

> On Thu, Mar 5, 2020 at 4:24 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>> On 05/03/20 15:01, Jon Doron wrote:
>>> Signed-off-by: Jon Doron <arilou@gmail.com>
>>> ---
>>> include/uapi/linux/kvm.h | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h
>>> index 4b95f9a31a2f..9b4d449f4d20 100644
>>> --- a/include/uapi/linux/kvm.h
>>> +++ b/include/uapi/linux/kvm.h
>>> @@ -200,6 +200,7 @@ struct kvm_hyperv_exit {
>>> __u64 input;
>>> __u64 result;
>>> __u64 params[2];
>>> + __u32 pad;
>>> } hcall;
>>> } u;
>>> };
>>>
>>
>> Can you explain the purpose of this patch?
>>
>> Paolo
>>
>