Re: [PATCH v2 1/4] x86/kvm/hyper-v: Align the hcall param for kvm_hyperv_exit

Paolo Bonzini
2020-03-05T16:45:25Z

On 05/03/20 16:52, Jon Doron wrote:
> bah you are right sorry :( but if ill do that ill break userspace no?

No, you'd just be making the padding explicit.

Paolo

>
> On Thu, Mar 5, 2020 at 5:30 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>> On 05/03/20 15:53, Jon Doron wrote:
>>> Vitaly recommended we will align the struct to 64bit...
>> Oh, then I think you actually should add a padding after "__u32 type;"
>> and "__u32 msr;" if you want to make it explicit. The patch, as is, is
>> not aligning anything, hence my confusion.