RE: [PATCH v4 2/5] x86/hyper-v: Add synthetic debugger definitions

Vitaly Kuznetsov
2020-03-12T13:51:31Z

Michael Kelley <mikelley@microsoft.com> writes:

> I'm flexible, and trying to not be a pain-in-the-neck. :-) What would
> the KVM guys think about putting the definitions in a KVM specific
> #include file, and clearly marking them as deprecated, mostly
> undocumented, and used only to support debugging old Windows
> versions?

I *think* we should do the following: defines which *are* present in
TLFS doc (e.g. HV_FEATURE_DEBUG_MSRS_AVAILABLE,
HV_STATUS_OPERATION_DENIED, ...) go to asm/hyperv-tlfs.h, the rest
(syndbg) stuff goes to kvm-specific include (I'd suggest we just use
hyperv.h we already have).

What do you think?

--
Vitaly