From: Jon Doron <arilou@gmail.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: kvm@vger.kernel.org, linux-hyperv@vger.kernel.org
Subject: Re: [PATCH v4 1/5] x86/kvm/hyper-v: Explicitly align hcall param for kvm_hyperv_exit
Date: Tue, 10 Mar 2020 19:14:12 +0200 [thread overview]
Message-ID: <20200310171412.GC13767@jondnuc> (raw)
In-Reply-To: <87k13sb14a.fsf@vitty.brq.redhat.com>
On 10/03/2020, Vitaly Kuznetsov wrote:
>Jon Doron <arilou@gmail.com> writes:
>
>> Signed-off-by: Jon Doron <arilou@gmail.com>
>> ---
>> include/uapi/linux/kvm.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h
>> index 4b95f9a31a2f..7acfd6a2569a 100644
>> --- a/include/uapi/linux/kvm.h
>> +++ b/include/uapi/linux/kvm.h
>> @@ -189,6 +189,7 @@ struct kvm_hyperv_exit {
>> #define KVM_EXIT_HYPERV_SYNIC 1
>> #define KVM_EXIT_HYPERV_HCALL 2
>> __u32 type;
>> + __u32 pad;
>> union {
>> struct {
>> __u32 msr;
>
>Sorry if I missed something but I think the suggestion was to pad this
>'msr' too (in case we're aiming at making padding explicit for the whole
>structure). Or is there any reason to not do that?
>
>Also, I just noticed that we have a copy of this definition in
>Documentation/virt/kvm/api.rst - it will need to be updated (and sorry
>for not noticing it earlier).
>
>--
>Vitaly
>
Heh sure no problem will fix in v5, but going to wait for a verdict on
the location for the new CPUID leafs and MSRs for the synthetic
debugger.
-- Jon.
next prev parent reply other threads:[~2020-03-10 17:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 18:20 [PATCH v4 0/5] x86/kvm/hyper-v: add support for synthetic debugger Jon Doron
2020-03-09 18:20 ` [PATCH v4 1/5] x86/kvm/hyper-v: Explicitly align hcall param for kvm_hyperv_exit Jon Doron
2020-03-10 16:55 ` Vitaly Kuznetsov
2020-03-10 17:14 ` Jon Doron [this message]
2020-03-09 18:20 ` [PATCH v4 2/5] x86/hyper-v: Add synthetic debugger definitions Jon Doron
2020-03-09 21:00 ` Michael Kelley
2020-03-10 3:24 ` Jon Doron
2020-03-10 3:53 ` Michael Kelley
2020-03-10 4:28 ` Jon Doron
2020-03-10 14:23 ` Wei Liu
2020-03-12 13:51 ` Vitaly Kuznetsov
2020-03-12 14:59 ` Michael Kelley
2020-03-12 19:12 ` Jon Doron
2020-03-12 19:32 ` Michael Kelley
2020-03-12 19:34 ` Jon Doron
2020-03-09 18:20 ` [PATCH v4 3/5] x86/kvm/hyper-v: Add support for synthetic debugger capability Jon Doron
2020-03-09 18:20 ` [PATCH v4 4/5] x86/kvm/hyper-v: enable hypercalls regardless of hypercall page Jon Doron
2020-03-09 18:20 ` [PATCH v4 5/5] x86/kvm/hyper-v: Add support for synthetic debugger via hypercalls Jon Doron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310171412.GC13767@jondnuc \
--to=arilou@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox