Re: [PATCH v1 06/22] hw/pci: introduce pci_device_set/unset_iommu_context()

Peter Xu
2020-03-23T21:15:19Z

On Sun, Mar 22, 2020 at 05:36:03AM -0700, Liu Yi L wrote:

[...]

> +AddressSpace *pci_device_iommu_address_space(PCIDevice *dev)
> +{
> + PCIBus *bus;
> + uint8_t devfn;
> +
> + pci_device_get_iommu_bus_devfn(dev, &bus, &devfn);
> + if (bus && bus->iommu_ops &&
> + bus->iommu_ops->get_address_space) {

Nit: Since we're moving it around, maybe re-align it to left bracket?
Same to below two places.

With the indent fixed:

Reviewed-by: Peter Xu <peterx@redhat.com>

> + return bus->iommu_ops->get_address_space(bus,
> + bus->iommu_opaque, devfn);
> }
> return &address_space_memory;
> }

--
Peter Xu