RE: [PATCH v1 06/22] hw/pci: introduce pci_device_set/unset_iommu_context()

Liu, Yi L
2020-03-24T10:02:10Z

> From: Peter Xu <peterx@redhat.com>
> Sent: Tuesday, March 24, 2020 5:15 AM
> To: Liu, Yi L <yi.l.liu@intel.com>
> Subject: Re: [PATCH v1 06/22] hw/pci: introduce
> pci_device_set/unset_iommu_context()
>
> On Sun, Mar 22, 2020 at 05:36:03AM -0700, Liu Yi L wrote:
>
> [...]
>
> > +AddressSpace *pci_device_iommu_address_space(PCIDevice *dev) {
> > + PCIBus *bus;
> > + uint8_t devfn;
> > +
> > + pci_device_get_iommu_bus_devfn(dev, &bus, &devfn);
> > + if (bus && bus->iommu_ops &&
> > + bus->iommu_ops->get_address_space) {
>
> Nit: Since we're moving it around, maybe re-align it to left bracket?
> Same to below two places.

got it. will do it.

> With the indent fixed:
>
> Reviewed-by: Peter Xu <peterx@redhat.com>

Thanks for the comments.

Regards,
Yi Liu