From: Christoph Hellwig <hch@infradead.org>
To: Yonghyun Hwang <yonghyun@google.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Kirti Wankhede <kwankhede@nvidia.com>,
Alex Williamson <alex.williamson@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Havard Skinnemoen <hskinnemoen@google.com>,
Moritz Fischer <mdf@kernel.org>
Subject: Re: [PATCH] vfio-mdev: support mediated device creation in kernel
Date: Thu, 26 Mar 2020 02:38:07 -0700 [thread overview]
Message-ID: <20200326093807.GB12078@infradead.org> (raw)
In-Reply-To: <CAEauFbww3X2WZuOvMbnhOD2ONBjqR-JS2BrxWPO=HqzXVcKakw@mail.gmail.com>
On Mon, Mar 23, 2020 at 02:33:11PM -0700, Yonghyun Hwang wrote:
> On Mon, Mar 23, 2020 at 4:14 AM Christoph Hellwig <hch@infradead.org> wrote:
> >
> > On Fri, Mar 20, 2020 at 10:59:10AM -0700, Yonghyun Hwang wrote:
> > > To enable a mediated device, a device driver registers its device to VFIO
> > > MDev framework. Once the mediated device gets enabled, UUID gets fed onto
> > > the sysfs attribute, "create", to create the mediated device. This
> > > additional step happens after boot-up gets complete. If the driver knows
> > > how many mediated devices need to be created during probing time, the
> > > additional step becomes cumbersome. This commit implements a new function
> > > to allow the driver to create a mediated device in kernel.
> >
> > Please send this along with your proposed user so that we can understand
> > the use. Without that new exports have no chance of going in anyway.
>
> My driver is still under development. Do you recommend me to implement
> an example code for the new exports and re-submit the commit?
Hell no. The point is that we don't add new APIs unless we have
actual users (not example code!). And as Alex mentioned the use case
is rather questionable anyway, so without a user that actually shows a
good use case which would remove those doubts it is a complete no-go.
next prev parent reply other threads:[~2020-03-26 9:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 17:59 [PATCH] vfio-mdev: support mediated device creation in kernel Yonghyun Hwang
2020-03-20 18:34 ` Alex Williamson
2020-03-20 20:46 ` Yonghyun Hwang
2020-03-20 20:59 ` Alex Williamson
2020-03-20 22:07 ` Yonghyun Hwang
2020-03-23 11:14 ` Christoph Hellwig
2020-03-23 21:33 ` Yonghyun Hwang
2020-03-26 9:38 ` Christoph Hellwig [this message]
2020-03-26 17:16 ` Yonghyun Hwang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326093807.GB12078@infradead.org \
--to=hch@infradead.org \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=hskinnemoen@google.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=yonghyun@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox